storage: test the persist sink's pipeline end to end - #38936
Draft
martykulma wants to merge 1 commit into
Draft
martykulma wants to merge 1 commit into
martykulma wants to merge 1 commit into
Conversation
martykulma
added this pull request to stack #38937
September 19, 2026 00:30
martykulma
changed the title
The writer had a harness of its own, driven by a script that stands in for what the minter would send. That cannot say whether the two agree, and the grouping a pinned snapshot gets is a property of the pair rather than of either operator. run_sink_pipeline wires the real minter into the real writer, so the ordering between a committed ceiling and the data it covers is the operators' own. run_mint_batch_descriptions covers the minter alone, which had no test at all. Both pinned scripts write one batch, the interleaved one included, which is where routing by description used to close and reopen a builder on every flip between the snapshot's time and the replication rows above it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
martykulma
force-pushed
the
maz-sink-pipeline-tests
branch
from
September 19, 2026 01:00
48729da to
8573f77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_batcheshad a harness of its own, driven by a script standing in forwhat the minter would send. That can't say whether the two agree, and the
grouping a pinned snapshot gets is a property of the pair.
run_sink_pipelinewires the real minter into the real writer, so the orderingbetween a committed ceiling and the data it covers is the operators' own.
run_mint_batch_descriptionscovers the minter alone, which had no test at all.Both pinned scripts write one batch, the interleaved one included, which is
where routing by description used to close and reopen a builder on every flip
between the snapshot's time and the replication rows above it.
🤖 Generated with Claude Code