<fix>[pciDevice]: add share error code

compute/src/main/java/org/zstack/compute/allocator/AttachedVolumePrimaryStorageAllocatorFlow.java

@@ -32,7 +32,7 @@ public class AttachedVolumePrimaryStorageAllocatorFlow extends AbstractHostAlloc
     public void allocate() {
         throwExceptionIfIAmTheFirstFlow();
 
-        if (VmOperation.NewCreate.toString().equals(spec.getVmOperation())) {
+        if (VmOperation.NewCreate.toString().equals(spec.getVmOperation()) || VmOperation.MigrateStorage.toString().equals(spec.getVmOperation())) {
             next(candidates);
             return;
         }

compute/src/main/java/org/zstack/compute/allocator/HostPrimaryStorageAllocatorFlow.java

@@ -142,11 +142,11 @@ private List<HostVO> filterHostHavingAccessiblePrimaryStorage(List<String> huuid
     private List<HostVO> allocateFromCandidates() {
         List<String> huuids = getHostUuidsFromCandidates();
         Set<String> requiredPsUuids = spec.getRequiredPrimaryStorageUuids();
-        if (!VmOperation.NewCreate.toString().equals(spec.getVmOperation())) {
-            return filterHostHavingAccessiblePrimaryStorage(huuids, spec);
-        } else {
+        if (VmOperation.NewCreate.toString().equals(spec.getVmOperation()) || VmOperation.MigrateStorage.toString().equals(spec.getVmOperation())) {
             huuids = filterHostHavingAccessiblePrimaryStorage(huuids, spec)
                     .stream().map(ResourceVO::getUuid).collect(Collectors.toList());
+        } else {
+            return filterHostHavingAccessiblePrimaryStorage(huuids, spec);
         }
 
         if (huuids.isEmpty()) {

compute/src/main/java/org/zstack/compute/allocator/TagAllocatorFlow.java

@@ -40,14 +40,15 @@ public class TagAllocatorFlow extends AbstractHostAllocatorFlow {
     private List<InstanceOfferingTagAllocatorExtensionPoint> instanceOfferingExtensions;
     private List<DiskOfferingTagAllocatorExtensionPoint> diskOfferingExtensions;
 
-    public TagAllocatorFlow() {
+    private void loadExtensions() {
         instanceOfferingExtensions = pluginRgty.getExtensionList(InstanceOfferingTagAllocatorExtensionPoint.class);
         diskOfferingExtensions = pluginRgty.getExtensionList(DiskOfferingTagAllocatorExtensionPoint.class);
     }
 
     @Override
     public void allocate() {
         throwExceptionIfIAmTheFirstFlow();
+        loadExtensions();
 
         if (!instanceOfferingExtensions.isEmpty()) {
             SimpleQuery<SystemTagVO> q  = dbf.createQuery(SystemTagVO.class);

compute/src/main/java/org/zstack/compute/host/HostApiInterceptor.java

@@ -11,10 +11,14 @@
 import org.zstack.header.apimediator.ApiMessageInterceptionException;
 import org.zstack.header.apimediator.ApiMessageInterceptor;
 import org.zstack.header.apimediator.StopRoutingException;
+import org.zstack.header.cluster.ClusterVO;
+import org.zstack.header.cluster.ClusterVO_;
 import org.zstack.header.host.*;
 import org.zstack.header.message.APIMessage;
+import org.zstack.header.zone.ManagementNetworkIpVersionManager;
 import org.zstack.utils.ShellResult;
 import org.zstack.utils.ShellUtils;
+import org.zstack.utils.network.IPv6NetworkUtils;
 import org.zstack.utils.network.NetworkUtils;
 
 import static org.zstack.core.Platform.argerr;
@@ -28,12 +32,19 @@
  * To change this template use File | Settings | File Templates.
  */
 public class HostApiInterceptor implements ApiMessageInterceptor {
+    private static final String INVALID_MANAGEMENT_IP_ERROR =
+            "managementIp[%s] is not a valid IPv4 address, IPv6 address, or hostname";
+    private static final String RESERVED_MANAGEMENT_IPV6_ERROR =
+            "managementIp[%s] is an IPv6 address that cannot be used as a management address";
+
     @Autowired
     private CloudBus bus;
     @Autowired
     private ErrorFacade errf;
     @Autowired
     private DatabaseFacade dbf;
+    @Autowired
+    private ManagementNetworkIpVersionManager managementNetworkIpVersionManager;
 
     private void setServiceId(APIMessage msg) {
         if (msg instanceof HostMessage) {
@@ -112,18 +123,70 @@ private void validate(APIDeleteHostMsg msg) {
 
     private void validate(APIUpdateHostMsg msg) {
         if (msg.getManagementIp() != null) {
+            msg.setManagementIp(validateManagementEndpoint(msg.getManagementIp()));
+
             SimpleQuery<HostVO> q = dbf.createQuery(HostVO.class);
             q.add(HostVO_.managementIp, Op.EQ, msg.getManagementIp());
             if (q.isExists()) {
                 throw new ApiMessageInterceptionException(argerr(ORG_ZSTACK_COMPUTE_HOST_10112, "there has been a host having managementIp[%s]", msg.getManagementIp()));
             }
+
+            String zoneUuid = Q.New(HostVO.class)
+                    .select(HostVO_.zoneUuid)
+                    .eq(HostVO_.uuid, msg.getUuid())
+                    .findValue();
+            managementNetworkIpVersionManager.validateEndpointInZone(zoneUuid, msg.getManagementIp(),
+                    "host", msg.getUuid(), ORG_ZSTACK_COMPUTE_HOST_10130);
         }
     }
 
     private void validate(APIAddHostMsg msg) {
-        if (!NetworkUtils.isIpv4Address(msg.getManagementIp()) && !NetworkUtils.isHostname(msg.getManagementIp())) {
-            throw new ApiMessageInterceptionException(argerr(ORG_ZSTACK_COMPUTE_HOST_10113, "managementIp[%s] is neither an IPv4 address nor a valid hostname", msg.getManagementIp()));
+        validateManagementEndpoint(msg);
+        String zoneUuid = Q.New(ClusterVO.class)
+                .select(ClusterVO_.zoneUuid)
+                .eq(ClusterVO_.uuid, msg.getClusterUuid())
+                .findValue();
+        managementNetworkIpVersionManager.validateEndpointInZone(zoneUuid, msg.getManagementIp(),
+                "host", msg.getName(), ORG_ZSTACK_COMPUTE_HOST_10130);
+    }
+
+    static void validateManagementEndpoint(APIAddHostMsg msg) {
+        String managementIp = msg.getManagementIp();
+        msg.setManagementIp(validateManagementEndpoint(managementIp));
+    }
+
+    static String validateManagementEndpoint(String managementIp) {
+        if (IPv6NetworkUtils.isIpv6Address(managementIp)) {
+            if (!IPv6NetworkUtils.isValidManagementIpv6Address(managementIp)) {
+                throw new ApiMessageInterceptionException(argerr(
+                        ORG_ZSTACK_COMPUTE_HOST_10129,
+                        RESERVED_MANAGEMENT_IPV6_ERROR,
+                        managementIp));
+            }
+        } else if (!isValidManagementEndpoint(managementIp)) {
+            throw new ApiMessageInterceptionException(argerr(
+                    ORG_ZSTACK_COMPUTE_HOST_10128,
+                    INVALID_MANAGEMENT_IP_ERROR,
+                    managementIp));
         }
+
+        if (IPv6NetworkUtils.isIpv6Address(managementIp)) {
+            return IPv6NetworkUtils.getIpv6AddressCanonicalString(managementIp);
+        }
+
+        return managementIp;
+    }
+
+    static String getManagementEndpointValidationErrorCode(String managementIp) {
+        if (IPv6NetworkUtils.isIpv6Address(managementIp)) {
+            return IPv6NetworkUtils.isValidManagementIpv6Address(managementIp) ? null : ORG_ZSTACK_COMPUTE_HOST_10129;
+        }
+
+        return isValidManagementEndpoint(managementIp) ? null : ORG_ZSTACK_COMPUTE_HOST_10128;
+    }
+
+    private static boolean isValidManagementEndpoint(String endpoint) {
+        return IPv6NetworkUtils.isValidManagementEndpoint(endpoint);
     }
 
     private void validate(APIChangeHostStateMsg msg){

compute/src/main/java/org/zstack/compute/host/HostBase.java

@@ -188,6 +188,8 @@ protected void handleApiMessage(APIMessage msg) {
             handle((APIPowerResetHostMsg) msg);
         } else if (msg instanceof APIGetHostPowerStatusMsg) {
             handle((APIGetHostPowerStatusMsg) msg);
+        } else if (msg instanceof APIGetBlockDevicesMsg) {
+            handle((APIGetBlockDevicesMsg) msg);
         } else {
             bus.dealWithUnknownMessage(msg);
         }
@@ -214,6 +216,27 @@ public void run(MessageReply reply) {
         });
     }
 
+    private void handle(APIGetBlockDevicesMsg msg) {
+        APIGetBlockDevicesEvent event = new APIGetBlockDevicesEvent(msg.getId());
+        GetBlockDevicesOnHostMsg gmsg = new GetBlockDevicesOnHostMsg();
+        gmsg.setHostUuid(msg.getHostUuid());
+        gmsg.setIncludeInUse(msg.isIncludeInUse());
+        bus.makeTargetServiceIdByResourceUuid(gmsg, HostConstant.SERVICE_ID, msg.getHostUuid());
+        bus.send(gmsg, new CloudBusCallBack(msg) {
+            @Override
+            public void run(MessageReply reply) {
+                if (!reply.isSuccess()) {
+                    event.setSuccess(false);
+                    event.setError(reply.getError());
+                } else {
+                    GetBlockDevicesOnHostReply r = reply.castReply();
+                    event.setBlockDevices(r.getBlockDevices());
+                }
+                bus.publish(event);
+            }
+        });
+    }
+
     private void handle(APIPowerResetHostMsg msg) {
         final APIPowerResetHostEvent event = new APIPowerResetHostEvent(msg.getId());
         RebootHostMsg rebootHostMsg = new RebootHostMsg();

compute/src/main/java/org/zstack/compute/vm/VmAllocateHostFlow.java

@@ -6,7 +6,6 @@
 import org.zstack.core.cloudbus.CloudBus;
 import org.zstack.core.cloudbus.CloudBusCallBack;
 import org.zstack.core.db.DatabaseFacade;
-import org.zstack.core.db.Q;
 import org.zstack.core.db.SQL;
 import org.zstack.core.errorcode.ErrorFacade;
 import org.zstack.header.allocator.*;
@@ -15,7 +14,6 @@
 import org.zstack.header.core.workflow.Flow;
 import org.zstack.header.core.workflow.FlowRollback;
 import org.zstack.header.core.workflow.FlowTrigger;
-import org.zstack.header.errorcode.ErrorCode;
 import org.zstack.header.exception.CloudRuntimeException;
 import org.zstack.header.host.HostInventory;
 import org.zstack.header.host.HostVO;
@@ -24,8 +22,6 @@
 import org.zstack.header.message.APIMessage;
 import org.zstack.header.message.MessageReply;
 import org.zstack.header.network.l3.L3NetworkInventory;
-import org.zstack.header.storage.primary.PrimaryStorageClusterRefVO;
-import org.zstack.header.storage.primary.PrimaryStorageClusterRefVO_;
 import org.zstack.header.vm.*;
 import org.zstack.header.vm.VmInstanceConstant.VmOperation;
 import org.zstack.utils.CollectionUtils;
@@ -162,6 +158,7 @@ public void run(final FlowTrigger chain, Map data) {
         }
 
         AllocateHostMsg msg = this.prepareMsg(spec);
+        extEmitter.beforeVmAllocateHost(msg, spec);
 
         bus.send(msg, new CloudBusCallBack(chain) {
             @Override

compute/src/main/java/org/zstack/compute/vm/VmAllocateHostForStoppedVmFlow.java

@@ -92,6 +92,7 @@ public String call(L3NetworkInventory arg) {
         msg.setAvoidHostUuids(spec.getAvoidHostUuids());
         amsg = msg;
 
+        extEmitter.beforeVmAllocateHost(amsg, spec);
         bus.send(amsg, new CloudBusCallBack(chain) {
             @Override
             public void run(MessageReply reply) {

compute/src/main/java/org/zstack/compute/vm/VmCreateOnHypervisorFlow.java

@@ -33,10 +33,8 @@ public class VmCreateOnHypervisorFlow implements Flow {
     @Autowired
     private EventFacade evtf;
 
-    private final List<VmBeforeCreateOnHypervisorExtensionPoint> exts = pluginRgty.getExtensionList(VmBeforeCreateOnHypervisorExtensionPoint.class);
-
     private void fireExtensions(VmInstanceSpec spec) {
-        for (VmBeforeCreateOnHypervisorExtensionPoint ext : exts) {
+        for (VmBeforeCreateOnHypervisorExtensionPoint ext : pluginRgty.getExtensionList(VmBeforeCreateOnHypervisorExtensionPoint.class)) {
             ext.beforeCreateVmOnHypervisor(spec);
         }
     }

compute/src/main/java/org/zstack/compute/vm/VmInstanceBase.java

@@ -337,6 +337,10 @@ protected VmInstanceVO changeVmStateInDb(VmInstanceStateEvent stateEvent) {
     }
 
     protected VmInstanceVO changeVmStateInDb(VmInstanceStateEvent stateEvent, Runnable runnable) {
+        return changeVmStateInDb(stateEvent, runnable, null);
+    }
+
+    protected VmInstanceVO changeVmStateInDb(VmInstanceStateEvent stateEvent, Runnable runnable, String stateChangeSource) {
         VmInstanceState bs = self.getState();
         final VmInstanceState state = self.getState().nextState(stateEvent);
 
@@ -385,6 +389,7 @@ protected void scripts() {
             data.setVmUuid(self.getUuid());
             data.setOldState(bs.toString());
             data.setNewState(state.toString());
+            data.setStateChangeSource(stateChangeSource);
             data.setInventory(getSelfInventory());
             evtf.fire(VmCanonicalEvents.VM_FULL_STATE_CHANGED_PATH, data);
 
@@ -1024,17 +1029,7 @@ public void done(ErrorCodeList errorCodeList) {
                         String hostUuid = self.getHostUuid();
                         String suspectHostUuid = StringUtils.trimToNull(hostUuid);
                         String peerHostUuid = StringUtils.trimToNull(msg.getAccessiblePeerHostUuid());
-                        UpdateQuery sql = SQL.New(VmInstanceVO.class)
-                                .eq(VmInstanceVO_.uuid, self.getUuid())
-                                .set(VmInstanceVO_.state, VmInstanceState.Stopped)
-                                .set(VmInstanceVO_.hostUuid, null);
-
-                        if (hostUuid != null) {
-                            sql.set(VmInstanceVO_.lastHostUuid, hostUuid);
-                        }
-
-                        sql.update();
-                        refreshVO();
+                        changeVmStateInDb(VmInstanceStateEvent.stopped, null, HaStartVmInstanceMsg.class.getName());
                         if (suspectHostUuid == null) {
                             logger.debug(String.format("HA-start vm[%s]: skip creating pre-fence tag because suspect host is absent",
                                     self.getUuid()));

compute/src/main/java/org/zstack/compute/vm/VmInstanceExtensionPointEmitter.java

@@ -6,6 +6,7 @@
 import org.zstack.core.errorcode.ErrorFacade;
 import org.zstack.core.workflow.FlowChainBuilder;
 import org.zstack.header.Component;
+import org.zstack.header.allocator.AllocateHostMsg;
 import org.zstack.header.core.Completion;
 import org.zstack.header.core.NoErrorCompletion;
 import org.zstack.header.core.WhileDoneCompletion;
@@ -52,6 +53,7 @@ public class VmInstanceExtensionPointEmitter implements Component {
     private List<VmNicChangeStateExtensionPoint> vmNicChangeStateExtensionPoints;
     private List<SshKeyPairAssociateExtensionPoint> sshKeyPairAssociateExtensionPoints;
     private List<AfterUpdateVmNicMacExtensionPoint> afterUpdateVmNicMacExtensionPoints;
+    private List<BeforeVmAllocateHostExtensionPoint> beforeVmAllocateHostExtensions;
 
     public List<ErrorCode> handleSystemTag(String vmUuid, List<String> tags){
         List<ErrorCode> errorCodes = new ArrayList<>();
@@ -614,6 +616,10 @@ public void cloneSshKeyPairsToVm(String originVmUuid, String destVmUuid) {
         });
     }
 
+    public void beforeVmAllocateHost(AllocateHostMsg msg, VmInstanceSpec spec) {
+        CollectionUtils.safeForEach(beforeVmAllocateHostExtensions, ext -> ext.beforeVmAllocateHost(msg, spec));
+    }
+
     private void populateExtensions() {
         VmInstanceBeforeStartExtensions = pluginRgty.getExtensionList(VmInstanceBeforeStartExtensionPoint.class);
         VmInstanceResumeExtensionPoints = pluginRgty.getExtensionList(VmInstanceResumeExtensionPoint.class);
@@ -632,6 +638,7 @@ private void populateExtensions() {
         vmNicChangeStateExtensionPoints = pluginRgty.getExtensionList(VmNicChangeStateExtensionPoint.class);
         sshKeyPairAssociateExtensionPoints = pluginRgty.getExtensionList(SshKeyPairAssociateExtensionPoint.class);
         afterUpdateVmNicMacExtensionPoints = pluginRgty.getExtensionList(AfterUpdateVmNicMacExtensionPoint.class);
+        beforeVmAllocateHostExtensions = pluginRgty.getExtensionList(BeforeVmAllocateHostExtensionPoint.class);
     }
 
     @Override

compute/src/main/java/org/zstack/compute/vm/VmInstantiateResourceForChangeImageFlow.java

@@ -25,8 +25,9 @@ public class VmInstantiateResourceForChangeImageFlow implements Flow {
     @Autowired
     private PluginRegistry pluginRgty;
 
-    private final List<ChangeVmImageExtensionPoint> extensions = pluginRgty.getExtensionList(ChangeVmImageExtensionPoint.class);
-
+    private List<ChangeVmImageExtensionPoint> getExtensions() {
+        return pluginRgty.getExtensionList(ChangeVmImageExtensionPoint.class);
+    }
 
     private void runExtensions(final Iterator<ChangeVmImageExtensionPoint> it, final VmInstanceSpec spec, final FlowTrigger chain) {
         if (!it.hasNext()) {
@@ -53,6 +54,7 @@ public void fail(ErrorCode errorCode) {
     @Override
     public void run(FlowTrigger chain, Map data) {
         VmInstanceSpec spec = (VmInstanceSpec) data.get(VmInstanceConstant.Params.VmInstanceSpec.toString());
+        List<ChangeVmImageExtensionPoint> extensions = getExtensions();
         for (ChangeVmImageExtensionPoint extp : extensions) {
             try {
                 extp.preBeforeInstantiateVmResource(spec);
@@ -89,6 +91,6 @@ public void fail(ErrorCode errorCode) {
     @Override
     public void rollback(FlowRollback chain, Map data) {
         VmInstanceSpec spec = (VmInstanceSpec) data.get(VmInstanceConstant.Params.VmInstanceSpec.toString());
-        rollbackExtensions(extensions.iterator(), spec, chain);
+        rollbackExtensions(getExtensions().iterator(), spec, chain);
     }
 }

compute/src/main/java/org/zstack/compute/vm/VmInstantiateResourcePostFlow.java

@@ -28,11 +28,13 @@ public class VmInstantiateResourcePostFlow implements Flow {
     @Autowired
     private PluginRegistry pluginRgty;
 
-    private final List<PostVmInstantiateResourceExtensionPoint> extensions = pluginRgty.getExtensionList(PostVmInstantiateResourceExtensionPoint.class);
-
+    private List<PostVmInstantiateResourceExtensionPoint> getExtensions() {
+        return pluginRgty.getExtensionList(PostVmInstantiateResourceExtensionPoint.class);
+    }
 
     public void run(FlowTrigger trigger, Map data) {
         VmInstanceSpec spec = (VmInstanceSpec) data.get(VmInstanceConstant.Params.VmInstanceSpec.toString());
+        List<PostVmInstantiateResourceExtensionPoint> extensions = getExtensions();
         for (PostVmInstantiateResourceExtensionPoint ext : extensions) {
             ext.postBeforeInstantiateVmResource(spec);
         }
@@ -64,7 +66,7 @@ public void fail(ErrorCode errorCode) {
     @Override
     public void rollback(FlowRollback trigger, Map data) {
         VmInstanceSpec spec = (VmInstanceSpec) data.get(VmInstanceConstant.Params.VmInstanceSpec.toString());
-        rollbackExtensions(extensions.iterator(), spec, trigger);
+        rollbackExtensions(getExtensions().iterator(), spec, trigger);
     }
 
     private void rollbackExtensions(final Iterator<PostVmInstantiateResourceExtensionPoint> iterator, final VmInstanceSpec spec, final FlowRollback trigger) {

compute/src/main/java/org/zstack/compute/vm/VmInstantiateResourcePreFlow.java

@@ -29,8 +29,9 @@ public class VmInstantiateResourcePreFlow implements Flow {
     @Autowired
     private PluginRegistry pluginRgty;
 
-    private final List<PreVmInstantiateResourceExtensionPoint> extensions = pluginRgty.getExtensionList(PreVmInstantiateResourceExtensionPoint.class);
-
+    private List<PreVmInstantiateResourceExtensionPoint> getExtensions() {
+        return pluginRgty.getExtensionList(PreVmInstantiateResourceExtensionPoint.class);
+    }
 
     private void runExtensions(final Iterator<PreVmInstantiateResourceExtensionPoint> it, final VmInstanceSpec spec, final FlowTrigger chain) {
         if (!it.hasNext()) {
@@ -61,6 +62,7 @@ public void fail(ErrorCode errorCode) {
     @Override
     public void run(FlowTrigger chain, Map data) {
         VmInstanceSpec spec = (VmInstanceSpec) data.get(VmInstanceConstant.Params.VmInstanceSpec.toString());
+        List<PreVmInstantiateResourceExtensionPoint> extensions = getExtensions();
         for (PreVmInstantiateResourceExtensionPoint extp : extensions) {
             try {
                 extp.preBeforeInstantiateVmResource(spec);
@@ -97,6 +99,6 @@ public void fail(ErrorCode errorCode) {
     @Override
     public void rollback(FlowRollback chain, Map data) {
         VmInstanceSpec spec = (VmInstanceSpec) data.get(VmInstanceConstant.Params.VmInstanceSpec.toString());
-        rollbackExtensions(extensions.iterator(), spec, chain);
+        rollbackExtensions(getExtensions().iterator(), spec, chain);
     }
 }