Skip to content

[5.4.10] cherry-pick ZSTAC 5.x storage fixes#4355

Closed
MatheMatrix wants to merge 3 commits into
5.4.10from
sync/shan.wu/backport/5.4.10/ZSTAC-86342-batch@@3
Closed

[5.4.10] cherry-pick ZSTAC 5.x storage fixes#4355
MatheMatrix wants to merge 3 commits into
5.4.10from
sync/shan.wu/backport/5.4.10/ZSTAC-86342-batch@@3

Conversation

@MatheMatrix

Copy link
Copy Markdown
Owner

Summary

Cherry-pick 5.x storage-related fixes for the 5.4.10 unresolved ZSTAC batch, excluding ZSTAC-78301 as requested.

Included Jira

  • ZSTAC-86342 via ZSTAC-80468
  • ZSTAC-86313 via ZSTAC-79756
  • ZSTAC-86308 via ZSTAC-61889

Commits

  • [migration]: fix failed to start vm after ceph to ceph offline migration.
  • [sharedblock]: convert memory snapshot install path from absolute path to protocol path
  • [snapshot]: ZSTAC-61889 handle late snapshot success

Testing

  • git diff --check zstack/5.4.10..HEAD

Related: ZSTAC-86342 ZSTAC-86313 ZSTAC-86308 ZSTAC-86316 ZSTAC-86295 ZSTAC-86297 ZSTAC-86339 ZSTAC-86331 ZSTAC-84638

sync from gitlab !10315

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cfe7badb-aab1-41f8-aa2e-9f6da50bab45

📥 Commits

Reviewing files that changed from the base of the PR and between f3fd7fa and eabf476.

⛔ Files ignored due to path filters (1)
  • conf/springConfigXml/volumeSnapshot.xml is excluded by !**/*.xml
📒 Files selected for processing (6)
  • compute/src/main/java/org/zstack/compute/vm/VmInstanceBase.java
  • conf/db/upgrade/V5.4.10__schema.sql
  • header/src/main/java/org/zstack/header/storage/snapshot/VolumeSnapshotDBSyncExtensionPoint.java
  • plugin/kvm/src/main/java/org/zstack/kvm/KVMHost.java
  • storage/src/main/java/org/zstack/storage/snapshot/VolumeSnapshotManagerImpl.java
  • test/src/test/groovy/org/zstack/test/integration/storage/snapshot/CreateSnapshotRollbackAfterDataPlaneSuccessCase.groovy

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/shan.wu/backport/5.4.10/ZSTAC-86342-batch@@3

Comment @coderabbitai help to get the list of available commands.

shan.wu added 3 commits July 6, 2026 17:38
…igration.

support starting vm without nic in other clusters.

Resolves/Related: ZSTAC-80468

Change-Id: I6370646f7a796265677a6a656c716f6867706d69
…e path to protocol path

convert memory snapshot install path from absolute path to protocol path

Resolves/Related: ZSTAC-79756

Change-Id: I6e626d68626461627a737765786a676e6b617064
Keep snapshot DB records when the hypervisor snapshot succeeds

but later control-plane flow fails.

KVMHost and VolumeSnapshotManagerImpl now share

syncVolumeSnapshotDBAfterTakeSnapshot for the DB update.

The regression case injects failure after data-plane success

through VolumeSnapshotCreationExtensionPoint.

Resolves: ZSTAC-61889

Change-Id: Ida2ef0ad95e7a2faf4d8db705d97b8807586802d
@MatheMatrix MatheMatrix force-pushed the sync/shan.wu/backport/5.4.10/ZSTAC-86342-batch@@3 branch from 4b26f25 to eabf476 Compare July 6, 2026 09:40
@zstack-robot-2 zstack-robot-2 deleted the sync/shan.wu/backport/5.4.10/ZSTAC-86342-batch@@3 branch July 7, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants