<fix>[snapshot]: ZSV-9792 keep incomplete snapshot groups

[MatheMatrix]

Summary

ZSV-9792 addresses single-volume snapshot residue after snapshot group creation fails. The create API can now persist an incomplete but deletable snapshot group instead of losing the cleanup entry.

Changes

• Add partial-success fields to batched snapshot create messages and replies.
• Enable partial success for APICreateVolumeSnapshotGroupMsg only.
• Persist group refs for all requested volumes; failed refs are marked snapshotDeleted=true while retaining volume and snapshot metadata.
• Prevent creating a VM from an incomplete snapshot group.
• Delete all-deleted snapshot groups cleanly.

Validation Summary

Core zstack modules compiled successfully in local checks. Whitespace checks passed. Premium integration verification is covered by the paired premium MR; local premium case execution was blocked by HTTP Nexus dependency resolution for 5.1.0 artifacts.

Records

Troubleshoot records are stored under the ZSV-9792 topic directory in the root workspace.

Resolves: ZSV-9792

sync from gitlab !10346

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 55159886-fa50-4f13-b2ef-662f4f4c8127

📥 Commits

Reviewing files that changed from the base of the PR and between 8a80419 and ac5b253.

📒 Files selected for processing (9)

• compute/src/main/java/org/zstack/compute/vm/VmInstanceApiInterceptor.java
• header/src/main/java/org/zstack/header/storage/snapshot/CreateVolumesSnapshotMsg.java
• header/src/main/java/org/zstack/header/storage/snapshot/CreateVolumesSnapshotOverlayInnerMsg.java
• header/src/main/java/org/zstack/header/storage/snapshot/CreateVolumesSnapshotOverlayInnerReply.java
• header/src/main/java/org/zstack/header/storage/snapshot/CreateVolumesSnapshotReply.java
• header/src/main/java/org/zstack/header/volume/APICreateVolumeSnapshotGroupMsg.java
• header/src/main/java/org/zstack/header/volume/CreateVolumeSnapshotGroupMessage.java
• storage/src/main/java/org/zstack/storage/snapshot/group/VolumeSnapshotGroupBase.java
• storage/src/main/java/org/zstack/storage/volume/VolumeBase.java

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch sync/tao.gan/ZSV-9792-r2@@2

---

_{Comment @coderabbitai help to get the list of available commands.}