Skip to content

docs(workflow): depends-on spans a repository owner, not an organization - #12717

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/recover-actions-corrections/depends-spans-repo-owner-organization--790b2c0c
Sep 9, 2026
Merged

docs(workflow): depends-on spans a repository owner, not an organization#12717
mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/recover-actions-corrections/depends-spans-repo-owner-organization--790b2c0c

Conversation

@jd

@jd jd commented Sep 7, 2026

Copy link
Copy Markdown
Member

The Pull Request Dependencies section said a Depends-On: header could point
at "other repositories with Mergify installed within your organization". The
constraint is the same repository owner, which may be a user account rather
than an organization. A reference to another owner is rendered with a
"depends-on conditions must have the same repository owner" warning and never
satisfies.

The section was also silent on what happens to a reference Mergify cannot
resolve — another owner, a repository without Mergify, or a pull request that
does not exist. None of those ever reach the depends-on attribute, so the
condition stays unsatisfied and blocks the merge rather than being skipped,
which is the behaviour a reader most needs to be told about.

This brings the page in line with the same rules already documented for the
depends-on merge protection in /merge-protections/builtin, which was
corrected and left this page behind.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_019V4gXwb2UucysW4xmB7bAw

Copilot AI lite review requested due to automatic review settings September 7, 2026 14:36
@jd

jd commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 docs(workflow): depends-on spans a repository owner, not an organization #12717 👈
2 docs(workflow): the fork rebase deprecation is not limited to bot_account #12718
3 docs(workflow): document when the review action actually posts #12719

@mergify

mergify Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 6 merge protections satisfied — ready to merge.

Show 6 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = renovate[bot]
    • all of:
      • author = mergify-ci-bot
      • -head ~= ^docs-agent/

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a small, low-risk docs clarification that matches the documented behavior elsewhere and introduces no internal-information leaks in the edited content.

Pull request overview

Updates the “Pull Request Dependencies” documentation for the merge workflow action to correctly describe the scope and failure behavior of Depends-On: references, aligning it with the already-corrected rules documented under merge protections.

Changes:

  • Clarifies that cross-repository dependencies are limited to the same repository owner (user or organization), not “within your organization”.
  • Documents that unresolvable references do not get skipped and will keep the merge blocked until corrected, including examples of unresolvable cases.
File summaries
File Description
src/content/docs/workflow/actions/merge.mdx Corrects Depends-On: scope (same repository owner) and explains blocking behavior for unresolvable references.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mergify
mergify Bot requested a review from a team September 7, 2026 14:38
@jd
jd marked this pull request as ready for review September 8, 2026 11:32
The Pull Request Dependencies section said a `Depends-On:` header could point
at "other repositories with Mergify installed within your organization". The
constraint is the same repository *owner*, which may be a user account rather
than an organization. A reference to another owner is rendered with a
"depends-on conditions must have the same repository owner" warning and never
satisfies.

The section was also silent on what happens to a reference Mergify cannot
resolve — another owner, a repository without Mergify, or a pull request that
does not exist. None of those ever reach the `depends-on` attribute, so the
condition stays unsatisfied and blocks the merge rather than being skipped,
which is the behaviour a reader most needs to be told about.

This brings the page in line with the same rules already documented for the
`depends-on` merge protection in /merge-protections/builtin, which was
corrected and left this page behind.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019V4gXwb2UucysW4xmB7bAw
Change-Id: I790b2c0c6e38ed5eff9ac587378765c72939f264
@jd
jd force-pushed the devs/jd/jd/recover-actions-corrections/depends-spans-repo-owner-organization--790b2c0c branch from 8a22459 to 550933e Compare September 8, 2026 12:39
@jd

jd commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

Revision history

# Type Changes Reason Date
1 initial 8a22459 2026-09-08 12:38 UTC
2 rebase 8a22459 → 550933e (rebase only) 2026-09-08 12:38 UTC

@mergify
mergify Bot deployed to Mergify Merge Protections September 8, 2026 12:39 Active
@jd

jd commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

Force-pushed, but nothing changed on this pull request — the stack was rebased on main while I addressed review comments on #12718 and #12719. The diff here is identical.

Compare: 8a22459…550933e

@mergify
mergify Bot requested a review from a team September 9, 2026 06:38
@mergify

mergify Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 5 minutes 48 seconds in the queue, including 2 minutes 20 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Sep 9, 2026
@mergify
mergify Bot merged commit bd33869 into main Sep 9, 2026
10 checks passed
@mergify
mergify Bot deleted the devs/jd/jd/recover-actions-corrections/depends-spans-repo-owner-organization--790b2c0c branch September 9, 2026 08:18
@mergify mergify Bot removed the queued label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants