merge queue: checking #12649 on main (90fc4ed) - #12759
Draft
mergify[bot] wants to merge 2 commits into
Draft
Conversation
DESIGN.md did not contain the word "diagram", and that silence is the whole reason this drifted: the diagram surface became the single largest violation of this document's own STRICT rules — no hex outside `tokens.css`, every dark remap in `theme.css`, components consume semantic tokens — while the document said nothing about it either way. A lint stops a color reaching a fence; only this explains what to write instead. The new section carries the role table, the three layout kinds, how a role becomes a surface/border/label, and the four surfaces that share the vocabulary. It also records the two judgment calls a reader would otherwise have to reverse-engineer: why `queued` and `mergify` share one accent, and why diagram borders lift toward white on dark when "the product palette does not flip" three sections above. The STRICT rules and the self-correction list gain the diagram case, and the SVG-hex exemption now says explicitly that diagrams are not covered by it. `AGENTS.md` gets the short version and the new command, per this file's own instruction to keep the two aligned. Also normalizes the diagram code to the site's American spelling. The three commits below this one were written in British English, which no other file in the repo uses — and the lint prints its guidance to contributors of a site that says "color". It is a style pass rather than a fix, folded in here because this is the commit that codifies house style; it changes no behavior, and the tests and the lint pass unchanged. Change-Id: Id961fd51cd73f70a9cab6ebc897c457e6dbfc581
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged when the schedule will match. 🎉
#12649 is queued for merge on branch main (90fc4ed).
This pull request has been created by Mergify to check the mergeability of #12649.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:schedule=Mon-Fri 09:00-17:30[Europe/Paris]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = renovate[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = diagram-tokenscheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/Required conditions to stay in the queue:
github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = renovate[bot]author = mergify-ci-bot-head ~= ^docs-agent/📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = diagram-tokenscheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/author != dependabot[bot]author != mergify-ci-botauthor != renovate[bot]head ~= ^docs-agent/