Skip to content

merge queue: checking #12758 on main (90fc4ed), stacked on #12649 - #12760

Closed
mergify[bot] wants to merge 4 commits into
mainfrom
mergify/merge-queue/e3c907e838
Closed

merge queue: checking #12758 on main (90fc4ed), stacked on #12649#12760
mergify[bot] wants to merge 4 commits into
mainfrom
mergify/merge-queue/e3c907e838

Conversation

@mergify

@mergify mergify Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🎉 This pull request has been checked successfully and will be merged soon. 🎉

#12758 is queued for merge on branch main (90fc4ed).

Stacked behind 1 pull request queued ahead of this batch, not part of it. These checks run on a tip that also carries its commits, so a failure here can come from it as much as from #12758.

Queued ahead of this batch:

This pull request has been created by Mergify to speculatively check the mergeability of #12758.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

Required conditions to stay in the queue:

---
checking_base_sha: 532282a1330ff61a15ddc9395dc4710ae1ab39f9
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 12758
    scopes: []
scopes: []
...

jd and others added 4 commits September 9, 2026 14:52
@jd
docs(design): write the diagram system into DESIGN.md
f0903b1 
DESIGN.md did not contain the word "diagram", and that silence is the whole
reason this drifted: the diagram surface became the single largest violation of
this document's own STRICT rules — no hex outside `tokens.css`, every dark remap
in `theme.css`, components consume semantic tokens — while the document said
nothing about it either way. A lint stops a color reaching a fence; only this
explains what to write instead.

The new section carries the role table, the three layout kinds, how a role
becomes a surface/border/label, and the four surfaces that share the vocabulary.
It also records the two judgment calls a reader would otherwise have to
reverse-engineer: why `queued` and `mergify` share one accent, and why diagram
borders lift toward white on dark when "the product palette does not flip" three
sections above. The STRICT rules and the self-correction list gain the diagram
case, and the SVG-hex exemption now says explicitly that diagrams are not
covered by it.

`AGENTS.md` gets the short version and the new command, per this file's own
instruction to keep the two aligned.

Also normalizes the diagram code to the site's American spelling. The three
commits below this one were written in British English, which no other file in
the repo uses — and the lint prints its guidance to contributors of a site that
says "color". It is a style pass rather than a fix, folded in here because this
is the commit that codifies house style; it changes no behavior, and the tests
and the lint pass unchanged.

Change-Id: Id961fd51cd73f70a9cab6ebc897c457e6dbfc581
@flagendijk89 @claude
fix(test-insights): link the four framework pages that only mentioned…
5e89044 
… the dashboard

pytest, playwright, rspec and vitest each ended a reader's setup with an
unlinked sentence — "Check the Test Insights dashboard afterward to view
execution metrics, detect flaky tests, and review test trends" — buried
in the middle of the CI workflow section. The other eleven framework
pages close with a "Verify and Review in Test Insights" section carrying
the actual dashboard link.

These four are the section's second page shape: they use a reporter,
plugin or gem that uploads directly with MERGIFY_TOKEN rather than
generating a JUnit report for the Mergify CI action to upload. That is
why the shared partial never reached them, and it is the same four pages
missing a Troubleshooting section.

Each now closes with the shared `_review-in-test-insights.mdx` partial
under the same heading the other eleven use, preceded by a line naming
what just happened so the partial's "You can then review..." has an
antecedent.

The shared troubleshooting partial is deliberately not added here. It is
written for the JUnit path — it talks about `report_path`, the CLI upload
step and workflow `if` conditions — and none of these four pages
reference any of that. Closing that gap needs framework-specific content
rather than a shared block.

Also normalises `:::tip` bodies in pytest and rspec to the 2-space indent
the rest of the docs use, and rewraps them to the surrounding column.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Change-Id: I7df67cc209a1cded4473b4667caf1653c7a8f73e
Claude-Session-Id: 18413631-aa75-4182-9e79-4c1ce31bb683
@mergify
Merge of #12649
532282a
@mergify
Merge of #12758
6d2ff8e
@mergify
mergify Bot deployed to Mergify Merge Protections September 9, 2026 16:06 Active
@mergify mergify Bot mentioned this pull request Sep 9, 2026
Merged
@mergify mergify Bot closed this Sep 10, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/e3c907e838 branch September 10, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jd @flagendijk89