Skip to content

merge queue: checking #12599 on main (90fc4ed), stacked on #12649 and #12758 - #12761

Draft
mergify[bot] wants to merge 6 commits into
mainfrom
mergify/merge-queue/a5d88a1970
Draft

merge queue: checking #12599 on main (90fc4ed), stacked on #12649 and #12758#12761
mergify[bot] wants to merge 6 commits into
mainfrom
mergify/merge-queue/a5d88a1970

Conversation

@mergify

@mergify mergify Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🎉 This pull request has been checked successfully and will be merged when the schedule will match. 🎉

#12599 is queued for merge on branch main (90fc4ed).

Stacked behind 2 pull requests queued ahead of this batch, not part of it. These checks run on a tip that also carries their commits, so a failure here can come from them as much as from #12599.

Queued ahead of this batch:

This pull request has been created by Mergify to speculatively check the mergeability of #12599.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

Required conditions to stay in the queue:

---
checking_base_sha: 89eecac8279cdd585f2e730c757461bf96fcef67
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 12599
    scopes: []
scopes: []
...

jd and others added 6 commits September 9, 2026 14:52
@jd
docs(design): write the diagram system into DESIGN.md
f0903b1 
DESIGN.md did not contain the word "diagram", and that silence is the whole
reason this drifted: the diagram surface became the single largest violation of
this document's own STRICT rules — no hex outside `tokens.css`, every dark remap
in `theme.css`, components consume semantic tokens — while the document said
nothing about it either way. A lint stops a color reaching a fence; only this
explains what to write instead.

The new section carries the role table, the three layout kinds, how a role
becomes a surface/border/label, and the four surfaces that share the vocabulary.
It also records the two judgment calls a reader would otherwise have to
reverse-engineer: why `queued` and `mergify` share one accent, and why diagram
borders lift toward white on dark when "the product palette does not flip" three
sections above. The STRICT rules and the self-correction list gain the diagram
case, and the SVG-hex exemption now says explicitly that diagrams are not
covered by it.

`AGENTS.md` gets the short version and the new command, per this file's own
instruction to keep the two aligned.

Also normalizes the diagram code to the site's American spelling. The three
commits below this one were written in British English, which no other file in
the repo uses — and the lint prints its guidance to contributors of a site that
says "color". It is a style pass rather than a fix, folded in here because this
is the commit that codifies house style; it changes no behavior, and the tests
and the lint pass unchanged.

Change-Id: Id961fd51cd73f70a9cab6ebc897c457e6dbfc581
@flagendijk89 @claude
fix(test-insights): link the four framework pages that only mentioned…
5e89044 
… the dashboard

pytest, playwright, rspec and vitest each ended a reader's setup with an
unlinked sentence — "Check the Test Insights dashboard afterward to view
execution metrics, detect flaky tests, and review test trends" — buried
in the middle of the CI workflow section. The other eleven framework
pages close with a "Verify and Review in Test Insights" section carrying
the actual dashboard link.

These four are the section's second page shape: they use a reporter,
plugin or gem that uploads directly with MERGIFY_TOKEN rather than
generating a JUnit report for the Mergify CI action to upload. That is
why the shared partial never reached them, and it is the same four pages
missing a Troubleshooting section.

Each now closes with the shared `_review-in-test-insights.mdx` partial
under the same heading the other eleven use, preceded by a line naming
what just happened so the partial's "You can then review..." has an
antecedent.

The shared troubleshooting partial is deliberately not added here. It is
written for the JUnit path — it talks about `report_path`, the CLI upload
step and workflow `if` conditions — and none of these four pages
reference any of that. Closing that gap needs framework-specific content
rather than a shared block.

Also normalises `:::tip` bodies in pytest and rspec to the 2-space indent
the rest of the docs use, and rewraps them to the surrounding column.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Change-Id: I7df67cc209a1cded4473b4667caf1653c7a8f73e
Claude-Session-Id: 18413631-aa75-4182-9e79-4c1ce31bb683
@jd
feat(docs): point a lost agent somewhere useful from the 404
03e56b1 
The 404 offered a search box and a link home. That works for a person; an
agent that followed a dead link gets a page with nothing machine-readable on
it, and a 404 is the one page where it has no other context to work from.

Add a short recovery list: the documentation index, `llms.txt`, the sitemap,
the API reference and the OpenAPI document — plus a note that appending `.md`
to any URL, or sending `Accept: text/markdown`, returns the Markdown source.
Useful to a human who mistyped a URL too.

Change-Id: Ibb77d5829360bfb5b6ae4b1768362c860f5670d8
@mergify
Merge of #12649
e58175a
@mergify
Merge of #12758
89eecac
@mergify
Merge of #12599
7108ee1
@mergify
mergify Bot deployed to Mergify Merge Protections September 9, 2026 19:50 Active
@mergify mergify Bot mentioned this pull request Sep 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jd @flagendijk89