docs(core): give key_for the reason that still holds - #1823
Conversation
`key_for` files `https://host/api` and `https://host/api/` under one entry, and its comment justified that by saying every request "replaces the base path outright". That stopped being true with #1819, which made `Client::join()` append a request path to the base's path prefix instead of replacing it, so GitHub Enterprise's `/api/v3` survives. The conclusion did not change, only the reason. `join()` now gives the base a trailing slash and strips the path's leading one, so both spellings send `/v1/user` to `https://host/api/v1/user`, and one credential entry for both is still right. The comment now says that. Comment only. Fixes MRGFY-8703 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Change-Id: Ibd81a3c529cb558d9e67d061ffe1d3d02dad2e34
Member
Author
|
This pull request is part of a Mergify stack:
|
Contributor
Merge Protections🔴 3 of 7 protections blocking · waiting on 👀 reviews and ⛓️ dependency
🔴 ⛓️ Depends-On RequirementsWaiting for
This rule is failing.Requirement based on the presence of
🔴 👀 Review RequirementsWaiting for
This rule is failing.
🔴 🔎 ReviewsWaiting for
This rule is failing.
Show 4 satisfied protections🟢 🤖 Continuous Integration
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
sileht
marked this pull request as ready for review
September 10, 2026 15:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
key_forfileshttps://host/apiandhttps://host/api/under oneentry, and its comment justified that by saying every request "replaces
the base path outright". That stopped being true with #1819, which made
Client::join()append a request path to the base's path prefixinstead of replacing it, so GitHub Enterprise's
/api/v3survives.The conclusion did not change, only the reason.
join()now gives thebase a trailing slash and strips the path's leading one, so both
spellings send
/v1/usertohttps://host/api/v1/user, and onecredential entry for both is still right. The comment now says that.
Comment only.
Fixes MRGFY-8703
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Depends-On: #1808