Repository navigation
Viewer: drop the redundant GLFW_CURSOR_NORMAL call that breaks iOS Safari - #7315
Merged
Merged
Conversation
…fari GLFW_CURSOR_NORMAL is GLFW's default cursor mode. Since Emscripten 4.0.11, its GLFW library implements this call with an unguarded document.exitPointerLock(), which throws on browsers without the Pointer Lock API (iOS Safari) and stops the viewer from starting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fedr
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Emscripten 4.0.11 (emscripten-core/emscripten#24603), its GLFW library implements
glfwSetInputMode( window, GLFW_CURSOR, GLFW_CURSOR_NORMAL )with an unguardeddocument.exitPointerLock(). In browsers without the Pointer Lock API (iOS Safari) that throwsTypeErrorduringViewer::launchInit_, and the web viewer never starts. With emsdk 4.0.10 the call fell back to a no-op.Reported upstream: emscripten-core/emscripten#28102, with a proposed change in emscripten-core/emscripten#28103.
GLFW_CURSOR_NORMALis GLFW's default mode, so the call does nothing on desktop. On web, cursor shapes don't go through cursor modes:ImGuiMenuturns off ImGui's GLFW cursor update and setscanvas.style.cursorthroughcustomSetCursor.Test plan:
Generated with Claude Code