Skip to content

Add an icon for Saven token - #1966

Open
vasyasai wants to merge 1 commit into
MetaMask:masterfrom
vasyasai:master
Open

vasyasai wants to merge 1 commit into
MetaMask:masterfrom
vasyasai:master

Conversation

@vasyasai

@vasyasai vasyasai commented Sep 18, 2026

Copy link
Copy Markdown

Note

Low Risk
Adds a standalone SVG under images/ with no runtime or security impact in this PR.

Overview
Adds images/saven_logo1.svg, a vector logo asset for the Saven token (922×919 viewBox, black path artwork).

This is a new static asset only—no app or config wiring appears in this diff, so follow-up work may be needed wherever other token icons are registered or referenced.

Reviewed by Cursor Bugbot for commit 26d9ebe. Bugbot is set up for automated code reviews on this repo. Configure here.

@vasyasai
vasyasai requested review from a team and MRabenda as code owners September 18, 2026 19:00

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 26d9ebe. Configure here.

Comment thread images/saven_logo1.svg
<path d="M2399 1753 c-13 -17 -13 -17 6 -3 11 8 22 16 24 17 2 2 0 3 -6 3 -6
0 -17 -8 -24 -17z"/>
</g>
</svg>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon never mapped to token

Medium Severity

The new saven_logo1.svg is not referenced from contract-map.json or a metadata entry, so clients never resolve it to a token and the icon will not appear in wallets.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 26d9ebe. Configure here.

Comment thread images/saven_logo1.svg
119 272 174 380 64 121 217 375 274 455 160 220 236 318 319 410 78 87 363
369 419 416 30 24 63 53 75 65 12 12 59 50 106 85 47 35 87 66 90 69 20 22 72
50 81 44 8 -4 9 -3 5 4 -22 35 626 405 849 485 22 8 92 33 155 57 303 113 620
188 945 224 212 24 219 24 530 21 222 -3 328 -8 450 -24z"/>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon renders as black square

Medium Severity

The first path fills the entire canvas with #000000 and treats the logo as a cutout, so the icon renders as a black square. On dark backgrounds the artwork disappears, and the artboard is not square.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 26d9ebe. Configure here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant