feat(kyc-controller): add session disclaimer fetching without sessionId - #10011
Merged
jiexi merged 7 commits intoAug 31, 2026
Merged
Conversation
jiexi
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d58a971. Configure here.
…ing-without-sessionId' into jl/kyc-controller-consents-fetching-without-sessionId
Messenger action typing collapses method overloads, so sessionId callers were typed as the country catalog path and broke the build. Expose fetchDisclaimersCatalog separately from fetchSessionDisclaimers. Co-authored-by: Cursor <cursoragent@cursor.com>
jiexi
deleted the
jl/kyc-controller-consents-fetching-without-sessionId
branch
August 31, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
fetchDisclaimerstofetchVendorDisclaimersfetchSessionDisclaimerswithout sessionId, using only country codeReferences
Checklist
Note
Medium Risk
Breaking rename affects any consumer calling
fetchDisclaimers; new catalog API is additive but splits consent validation paths for global vs session disclaimers.Overview
BREAKING: Renames
KycService.fetchDisclaimers/KycService:fetchDisclaimerstofetchVendorDisclaimers(vendor T&Cs atGET /vendors/{vendor}/disclaimers).KycController.loadDisclaimersand tests follow the new messenger action.Adds
fetchDisclaimersCatalog(GET /disclaimers?country=) for the pre-session idOS + SumSub legal catalog, exposed onKycServiceand messenger asKycService:fetchDisclaimersCatalog. ReturnsKycDisclaimersCatalog(idOS + kycProvider documents only).fetchSessionDisclaimersstays session-scoped and still requiressessionId; responses must includecredentialReusabilityConsentGiven, validated separately from the global catalog.Types/docs/exports updated (
FetchDisclaimersCatalogParams, ARCHITECTURE, CHANGELOG). The controller is not wired to callfetchDisclaimersCatalogyet—only the service surface is added.Reviewed by Cursor Bugbot for commit f8d8cfd. Bugbot is set up for automated code reviews on this repo. Configure here.