test(assets-controller): repro stale balance for fully-spent tokens (… - #10024
Draft
Kriys94 wants to merge 1 commit into
Draft
test(assets-controller): repro stale balance for fully-spent tokens (…#10024Kriys94 wants to merge 1 commit into
Kriys94 wants to merge 1 commit into
Conversation
…ASSETS-3856) The Accounts API reports a zero balance by omission: a token the account no longer holds is absent from balance responses rather than returned as "0". Subscription poll responses are applied with updateMode 'merge' — an object spread that can only add or overwrite keys — so an omitted token keeps its last non-zero balance through every poll cycle until app restart. Adds a repro driving the real subscription pipeline (unlock, startup fetch, AccountsApiDataSource poll) against a mocked Accounts API client, mirroring the reported scenario: a Linea account max-swaps USDC to USDT and the API omits USDC from subsequent polls. NOTE: the first test asserts the DESIRED behavior and intentionally FAILS on current code (expected "0", received "100"); it becomes the regression test once a fix lands. The second test (explicit zero through the same pipeline) passes, isolating the defect to omission handling. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ASSETS-3856)
The Accounts API reports a zero balance by omission: a token the account no longer holds is absent from balance responses rather than returned as "0". Subscription poll responses are applied with updateMode 'merge' — an object spread that can only add or overwrite keys — so an omitted token keeps its last non-zero balance through every poll cycle until app restart.
Adds a repro driving the real subscription pipeline (unlock, startup fetch, AccountsApiDataSource poll) against a mocked Accounts API client, mirroring the reported scenario: a Linea account max-swaps USDC to USDT and the API omits USDC from subsequent polls.
NOTE: the first test asserts the DESIRED behavior and intentionally FAILS on current code (expected "0", received "100"); it becomes the regression test once a fix lands. The second test (explicit zero through the same pipeline) passes, isolating the defect to omission handling.
Explanation
References
Checklist