fix: Fix wrapped/encrypted key and token - #10036
Open
jiexi wants to merge 2 commits into
Open
Conversation
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes the wrapping of the
encryptedDataKeyandukycCapabilityTokenwith incorrectly prepended the public key value to the encrypted/wrapped valueReferences
Checklist
Note
Medium Risk
Changes UKYC authorization wire crypto for data encryption key and capability token; wrong format would block session setup, but the change aligns with the server contract rather than altering business logic.
Overview
Corrects
wrapEncryptionKeysodataon UKYC authorizations is NaCl box ciphertext+tag only, notclientPublicKey || ciphertext. The session client public key is already sent oncreateUkycSession, so embedding it again broke the expectedCapabilityAuthorizationshape forencryptionDataKeyandukycCapabilityToken.Tests and JSDoc now assume the server opens the box with the registered client key plus
{ data, nonce }. A changelog Fixed entry documents the behavior.Reviewed by Cursor Bugbot for commit 835e646. Bugbot is set up for automated code reviews on this repo. Configure here.