Repository navigation
feat: use v2 of chomp associate address - #10687
Merged
Merged
Conversation
Jwhiles
force-pushed
the
john-associate-addrss-v2
branch
from
October 6, 2026 12:31
205b238 to
683a073
Compare
Jwhiles
added this pull request to stack #10688
October 6, 2026 13:13
Jwhiles
removed this pull request from stack #10688
October 7, 2026 08:44
Jwhiles
added this pull request to stack #10700
October 7, 2026 09:16
Jwhiles
force-pushed
the
john-associate-addrss-v2
branch
2 times, most recently
from
October 26, 2026 10:23
c915dd3 to
bd4de14
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Jwhiles
force-pushed
the
john-associate-addrss-v2
branch
2 times, most recently
from
October 26, 2026 14:12
e91dc1e to
52bd986
Compare
Includes: - feat: add v2 auth address methods to chomp service - feat: use v2 address association in the money account upgrade associate step - feat!: remove v1 associateAddress from chomp service - chore: add PR link to changelog entries Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Jwhiles
force-pushed
the
john-associate-addrss-v2
branch
from
October 26, 2026 14:51
52bd986 to
4749bdf
Compare
Jwhiles
marked this pull request as ready for review
October 26, 2026 15:28
MoMannn
approved these changes
Oct 26, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR updates the chomp service API to add the new v2 associate address endpoints and remove the v1 endpoints. It then also updates the consumer of this change (the money account upgrade controller) to use these new endpoints.
The chomp api service remains 'dumb', in that it doesn't handle signing anything for the address association. This is handled in the money upgrade controller's associate address step.
Note, the new chomp version that implements these endpoints is not released yet, so this PR will be blocked until that is done.
References
musd-1246
Checklist
Note
High Risk
Breaking removal of v1 association and messenger actions affects all consumers; the upgrade path changes auth/signing behavior tied to profile–address linking.
Overview
BREAKING: Replaces CHOMP v1 address association (
associateAddress/POST /v1/auth/address) with a two-step v2 flow:createAddressChallenge(POST /v2/auth/address/challenge) returns a single-use SIWE message (includingASSOCIATEandASSOCIATE_SUCCESSORwith optionalpredecessorAddress), thenassociateAddressV2(POST /v2/auth/address) submitschallengeId+ signature. Non-2xx API failures now throwChompApiErrorwith an optional CHOMPcodeparsed from the response body, applied across existing CHOMP service methods.Money account upgrade is updated to match: the
associate-addressstep requests a challenge, signs the returned message (notCHOMP Authentication {timestamp}), submits v2, and retries once when the API returnsCHALLENGE_INVALID_OR_EXPIRED. Messenger allowances switch fromChompApiService:associateAddresstocreateAddressChallengeandassociateAddressV2.Reviewed by Cursor Bugbot for commit 4749bdf. Bugbot is set up for automated code reviews on this repo. Configure here.