Repository navigation
docs(design): drop the tab bar recipe now that Miakapp draws the bar - #40
Merged
Merged
Conversation
… cli 4.0.0-alpha.15 components.css no longer offers a bottom tab bar, which the guide tells apps not to draw. The gallery keeps its mock of the Miakapp bar in its own styles and names home.bar.setButtons() and the 96 px bottom padding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
components.css offered a bottom tab bar recipe while the design guide tells apps not to draw one (Miakapp's bar floats at the bottom, and homes add buttons with
home.bar.setButtons). The recipe moves into the gallery's own styles, where it only mocks the Miakapp bar; the gallery note nameshome.bar.setButtons()and the 96 px bottom padding. CLI 4.0.0-alpha.15.bun run checkpasses (223 tests).