Skip to content

fix(minimax-bot): allow settings panels to scroll in narrow windows - #42

Merged
MyPrototypeWhat merged 1 commit into
MiniMax-AI:mainfrom
ghalibjan:fix/minimax-bot-settings-scroll
Oct 20, 2026
Merged

MyPrototypeWhat merged 1 commit into
MiniMax-AI:mainfrom
ghalibjan:fix/minimax-bot-settings-scroll

Conversation

@ghalibjan

@ghalibjan ghalibjan commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Opening Tasks and approvals in a MiniMax Bot pane no wider than 760 CSS pixels clips long task descriptions/lists, and scrolling cannot reach the remaining content. At this breakpoint, settings switch to a column layout, but .set-main retains its automatic minimum height and expands beyond the modal, whose overflow: hidden clips it.

Set min-height: 0 on .set-main so it can shrink below the navigation and let the existing .set-body { overflow-y: auto } work. All settings tabs share this container; navigation, headings, and the close button stay visible.

Validation

  • npm run check: passed, including 69 repository tests; minimax-bot validates without warnings.
  • node --test tests/*.test.mjs from the plugin directory: 200 passed.
  • Headless Chromium 151 on macOS, loading the actual client modules with synthetic data: verified all 7 settings tabs at 720x900, 760x600, 761x600, 1280x900, 720x360, and 480x600 (42 cases). Wheel scrolling reaches the bottom, the content stays inside the modal, headings stay fixed, and Escape closes the dialog. No page errors.
  • Before/after at 720x900: the Tasks body previously grew to 4248px and was clipped; it now has a 564px viewport and scrolls to scrollTop = 3684.
  • git diff --check: passed.

The repository check has six pre-existing README warnings in unrelated plugins: missing Tested environment / Data & access headings in mcode-token-usage-board and mcode-usage-monitor (four), and missing minimum client versions in xinyu-daily and anatomy-gallery (two).

Desktop-host installation remains unverified; browser checks used a standalone fixture with the real client CSS and panel rendering code. No real conversations, task data, or Agent turns were used.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@MyPrototypeWhat MyPrototypeWhat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! min-height: 0 on .set-main is the right fix: in the stacked (≤760px) layout the flex child was sizing to its content and getting clipped by the modal's overflow: hidden. The change is scoped to that one rule, so the wide layout is unaffected. Optional: consider bumping the minimax-bot patch version so already-installed users pick up the fix.

@MyPrototypeWhat
MyPrototypeWhat merged commit 9060bfc into MiniMax-AI:main Oct 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants