Repository navigation
Conversation
ZEVIN17
marked this pull request as ready for review
October 22, 2026 11:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
downloadSourceFilerejects a 200 response with invalid content headers without cancelling its body, leaving the rejected download stream open.downloadSkillContentalready cancels its body on the equivalent path.Cancel the Source File response body before returning the existing typed error, and ignore cancellation rejections. Normal downloads, request counts, protocol validation and size limits remain unchanged. Regression tests cover every header rejection condition, cancellation failure, absent bodies and valid empty/nonempty downloads.
AI-assisted implementation. An independent static review found no blocking issues.
Tests
git diff --check: passed.Go, database, Web/Playwright, the full repository gate and live-provider acceptance were not run.
Need help on this PR? Tag
@codesmith-botwith what you need.