Skip to content

[Bug] A resumed session stream closes before a queued message is drained, so the answer never reaches the client #527

Open

Description

@modacker

Title

A resumed session stream closes before a queued message is drained, so the answer never reaches the client

Where

packages/local-runtime-v2/src/application/conversation/conversation-application.ts
and packages/local-runtime-v2/src/service/session-system/stream/session-stream-service.ts

Reproduction

  1. Start a session and let a turn run.
  2. While it runs, queue a message.
  3. Reload the client, so it resumes the session.
  4. The queued message drains and its answer is produced, but the client never
    sees it, and the queue row is not cleared.

Why

Two defects stack.

The liveness check reads a lagging projection. Whether a resumed stream
is live or replay-only is decided from the session's persisted status, and
that status is an asynchronous projection of the state events. While a turn
is still running it can read as idle. The runtime then hands the client a
replay-only stream that closes, and the answer committed later never reaches
it. The runtime contradicts itself: asked "is there an active turn?" it says
yes, and in the next moment it says idle.

The authoritative answer is the active turn itself.

The stream waits for a terminal event that will not come. A stream that
follows a turn that has already ended waits for that turn's terminal event,
which was published before the client attached. The wait never resolves, so
the stream hangs instead of ending at the replay point.

The stream has to remember which turn the last terminal event belonged to,
and end at the replay point when it follows a turn that already ended.

Impact

Every client that resumes a session is affected, not only the WebUI. The
user sees a queued message that never gets an answer and a queue row that
never clears.

Expected

  • the liveness decision uses the authoritative active turn
  • a stream that follows an already-ended turn ends at the replay point
    instead of waiting forever

Notes

The client can re-read the transcript and the queue once its event channel is
ready, and that covers the projection the client holds. It cannot cover the
frame itself: the browser's event channel carries lifecycle events only, and
the live stream frames travel on their own connection. The client also must
not set the "drain queued" flag on its own, because that flag starts the
queued turn as a side effect.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions