Skip to content

Replace Rack::File with Rack::Files - #668

Open
SergiuLupaiescu wants to merge 1 commit into
MiniProfiler:masterfrom
SergiuLupaiescu:fix/rack-files
Open

SergiuLupaiescu wants to merge 1 commit into
MiniProfiler:masterfrom
SergiuLupaiescu:fix/rack-files

Conversation

@SergiuLupaiescu

@SergiuLupaiescu SergiuLupaiescu commented Oct 19, 2026 •

Copy link
Copy Markdown

Fixes #659.

Rack::File was removed in Rack 3. The version check added in #604 correctly uses Rack::Files for Rack >= 2.1.0 but the else branch referencing the removed constant was still present, causing a NameError in environments where the else branch could be triggered.

Drops the branch entirely, Rack < 2.1.0 is no longer supported.

@SergiuLupaiescu
SergiuLupaiescu marked this pull request as ready for review October 19, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NameError: uninitialized constant Rack::File in Rails 8.1 (Rack 3 compatibility)

1 participant