Skip to content

fix: unk token for unigrams #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephantul merged 1 commit into from
Aug 28, 2026
Merged

fix: unk token for unigrams #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions model2vec/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import json
import math
import os
import warnings
Expand Down Expand Up @@ -67,11 +68,7 @@ def __init__(
self.token_mapping: np.ndarray | None = token_mapping

self.tokenizer = tokenizer
self.unk_token_id: int | None
if hasattr(self.tokenizer.model, "unk_token") and self.tokenizer.model.unk_token is not None:
self.unk_token_id = tokenizer.get_vocab()[self.tokenizer.model.unk_token]
else:
self.unk_token_id = None # pragma: no cover # Doesn't actually happen, but can happen.
self.unk_token_id = _get_unk_token_id(self.tokenizer)

self.median_token_length = int(np.median([len(token) for token in self.tokens]))
self.config = config or {}
Expand Down Expand Up @@ -559,3 +556,16 @@ def _loading_helper(
quantize_to=quantize_to,
dimensionality=dimensionality,
)


def _get_unk_token_id(tokenizer: Tokenizer) -> int | None:
"""Get the unk token id."""
model = tokenizer.model
# Wordpiece + BPE + Word level
if hasattr(model, "unk_token"):
token = model.unk_token
if token is None:
return None
return tokenizer.token_to_id(token)
# Unigram
return json.loads(tokenizer.to_str())["model"].get("unk_id")
Loading