Skip to content

DEVOPS-1218: Improvements to the dependabot PRs for .pre-commit-hooks - #222

Merged
RomFloreani merged 6 commits into
mainfrom
DEVOPS-1218
Sep 3, 2026
Merged

DEVOPS-1218: Improvements to the dependabot PRs for .pre-commit-hooks#222
RomFloreani merged 6 commits into
mainfrom
DEVOPS-1218

Conversation

@RomFloreani

@RomFloreani RomFloreani commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

DEVOPS-1218 - Improvements to the dependabot PRs for .pre-commit-hooks. (Auto-merge, skip jira issue key, and run .pre-commit on all files)

Copilot AI lite review requested due to automatic review settings August 26, 2026 13:39
@github-actions github-actions Bot changed the title Devops 1218 DEVOPS-1218: Improvements to the dependabot PRs for .pre-commit-hooks. (Auto-merge, skip jira issue key, and run .pre-commit on all files) Aug 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves automation around Dependabot PRs that bump the .pre-commit-hooks group by ensuring pre-commit runs appropriately, Jira key enforcement is skipped for expected bot PRs, and eligible Dependabot PRs can be auto-merged.

Changes:

  • Update reusable pre-commit workflow to run pre-commit on all files for Dependabot pre-commit-hooks bumps.
  • Extend Jira PR actions workflow to exempt Dependabot pre-commit-hooks PRs from requiring a Jira issue key.
  • Expand Dependabot auto-merge workflow to allow multiple Dependabot groups and add group validation logic.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.github/workflows/reusable-pre_commit.yml Adds conditional logic to run pre-commit on all files for Dependabot pre-commit-hooks PRs.
.github/workflows/reusable-jira-pr_actions.yml Adds Dependabot pre-commit-hooks exemption path for Jira key enforcement.
.github/workflows/reusable-dependabot-auto-merge.yml Renames/expands inputs to allow multiple groups and validates group membership before auto-merge.
.github/workflows/pre-commit.yml Adds clarification comments for PR trigger scope supporting required checks for auto-merge.
.github/workflows/dependabot-auto-merge.yml Switches to calling the local reusable auto-merge workflow and passes multiple allowed groups.
Suppressed comments (1)

.github/workflows/reusable-pre_commit.yml:91

  • Same as above: use a path-segment match for the Dependabot group to avoid accidentally treating other branches as pre-commit-hooks bumps.
        if: ${{ github.event_name == 'pull_request' && github.event.pull_request.user.login == 'dependabot[bot]' && contains(github.head_ref, 'pre-commit-hooks') }}

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/reusable-dependabot-auto-merge.yml
Comment thread .github/workflows/dependabot-auto-merge.yml
Comment thread .github/workflows/reusable-jira-pr_actions.yml Outdated
Comment thread .github/workflows/reusable-pre_commit.yml Outdated
RomFloreani and others added 2 commits August 28, 2026 13:30
- Add IS_DEPENDABOT_PRECOMMIT exemption in reusable JIRA PR checks.
- Convert reusable-dependabot-auto-merge to accept a list of groups.
- Pass mirageo-ci-tools and pre-commit-hooks groups from caller.
- Run all pre-commit hooks on Dependabot pre-commit-hooks PRs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

⚠️ Force push detected - Previous Copilot review comments may no longer be relevant to the current code. Please resolve any outdated threads and re-request a Copilot review when ready.

@RomFloreani
RomFloreani requested a review from sebhmg August 31, 2026 13:06
@sebhmg sebhmg changed the title DEVOPS-1218: Improvements to the dependabot PRs for .pre-commit-hooks. (Auto-merge, skip jira issue key, and run .pre-commit on all files) DEVOPS-1218: Improvements to the dependabot PRs for .pre-commit-hooks Sep 2, 2026
Comment thread .github/workflows/pre-commit.yml Outdated

@sebhmg sebhmg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments and suggestions

Comment thread .github/workflows/reusable-dependabot-auto-merge.yml Outdated
Comment thread .github/workflows/reusable-jira-pr_actions.yml Outdated
Comment thread .github/workflows/reusable-jira-pr_actions.yml Outdated
Comment thread .github/workflows/reusable-pre_commit.yml Outdated
Comment thread .github/workflows/reusable-pre_commit.yml Outdated
Comment thread .github/workflows/reusable-pre_commit.yml Outdated
sebhmg
sebhmg previously approved these changes Sep 2, 2026
@sebhmg

sebhmg commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

good to merge pending test on modified precommit config

@RomFloreani

Copy link
Copy Markdown
Contributor Author

Without editing anything in pre-commit

image

With edits in Pre-commit file:

image

@RomFloreani
RomFloreani merged commit 7241532 into main Sep 3, 2026
14 checks passed
@RomFloreani
RomFloreani deleted the DEVOPS-1218 branch September 3, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants