GEOPY-3044: Investigate slow IP inversion - #475
Open
domfournier wants to merge 5 commits into
Open
Conversation
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is aimed at reproducing/investigating slow IP inversion behavior by switching the mira-simpeg dependency to a GEOPY-3044 branch and updating the associated lockfiles/environment locks to the newly-resolved SimPEG commit.
Changes:
- Point
mira-simpegto theGEOPY-3044git ref and re-resolve conda lockfiles to a new SimPEG commit SHA. - Refresh conda-lock outputs for Python 3.12/3.13 (including some additional package/build updates).
- Adjust “full run” (
__main__) parameters in severaltests/run_tests/*driver scripts (cell size 20 → 5).
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/run_tests/driver_rotated_gradients_test.py | Adjusts __main__ full-run mesh cell size. |
| tests/run_tests/driver_mag_test.py | Adjusts __main__ full-run mesh cell size. |
| tests/run_tests/driver_joint_surveys_test.py | Adjusts __main__ full-run mesh cell size. |
| tests/run_tests/driver_ip_test.py | Adjusts __main__ full-run mesh cell size. |
| tests/run_tests/driver_dc_test.py | Adjusts __main__ full-run mesh cell size. |
| pyproject.toml | Switches mira-simpeg git rev to GEOPY-3044. |
| py-3.13.conda-lock.yml | Updates resolved packages + mira-simpeg commit for py3.13 lock. |
| py-3.12.conda-lock.yml | Updates resolved packages + mira-simpeg commit for py3.12 lock. |
| environments/py-3.13-win-64.conda.lock.yml | Updates pinned environment packages and mira-simpeg commit (win, py3.13). |
| environments/py-3.13-win-64-dev.conda.lock.yml | Updates pinned dev environment packages and mira-simpeg commit (win, py3.13). |
| environments/py-3.13-linux-64.conda.lock.yml | Updates pinned environment packages and mira-simpeg commit (linux, py3.13). |
| environments/py-3.13-linux-64-dev.conda.lock.yml | Updates pinned dev environment packages and mira-simpeg commit (linux, py3.13). |
| environments/py-3.12-win-64.conda.lock.yml | Updates pinned environment packages and mira-simpeg commit (win, py3.12). |
| environments/py-3.12-win-64-dev.conda.lock.yml | Updates pinned dev environment packages and mira-simpeg commit (win, py3.12). |
| environments/py-3.12-linux-64.conda.lock.yml | Updates pinned environment packages and mira-simpeg commit (linux, py3.12). |
| environments/py-3.12-linux-64-dev.conda.lock.yml | Updates pinned dev environment packages and mira-simpeg commit (linux, py3.12). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sebhmg
previously approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-3044 - Investigate slow IP inversion
uses MiraGeoscience/simpeg#172