GEOPY-3041: Create Data groups for L2 and LP iterations on predicted data - #476
Open
domfournier wants to merge 14 commits into
Open
GEOPY-3041: Create Data groups for L2 and LP iterations on predicted data#476domfournier wants to merge 14 commits into
domfournier wants to merge 14 commits into
Conversation
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SimPEG driver save directives to create iteration-based data groupings (L2/LP) on predicted data outputs, and adjusts dependency/lockfiles to use a SimPEG branch containing the needed directive support.
Changes:
- Add a
SaveLPIterationsGroupsave directive for predicted data in the directives factory and update the model-group directive type used there. - Extend the gravity run test to assert that an
"L2 iterations"PropertyGroupexists on predicted data outputs. - Update
mira-simpeggit revision inpyproject.tomland refresh conda-lock outputs accordingly.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/run_tests/driver_grav_test.py | Adds assertions for the new L2-iterations grouping on predicted data. |
| simpeg_drivers/components/factories/directives_factory.py | Updates which grouping directives are added when saving iteration data/models. |
| pyproject.toml | Switches mira-simpeg dependency to a GEOPY-3041 git revision. |
| py-3.13.conda-lock.yml | Regenerated lockfile reflecting updated mira-simpeg resolution and transitive updates. |
| py-3.12.conda-lock.yml | Regenerated lockfile reflecting updated mira-simpeg resolution and transitive updates. |
| environments/py-3.13-win-64.conda.lock.yml | Updated environment lockfile snapshot for win-64 (py3.13). |
| environments/py-3.13-win-64-dev.conda.lock.yml | Updated dev environment lockfile snapshot for win-64 (py3.13). |
| environments/py-3.13-linux-64.conda.lock.yml | Updated environment lockfile snapshot for linux-64 (py3.13). |
| environments/py-3.13-linux-64-dev.conda.lock.yml | Updated dev environment lockfile snapshot for linux-64 (py3.13). |
| environments/py-3.12-win-64.conda.lock.yml | Updated environment lockfile snapshot for win-64 (py3.12). |
| environments/py-3.12-win-64-dev.conda.lock.yml | Updated dev environment lockfile snapshot for win-64 (py3.12). |
| environments/py-3.12-linux-64.conda.lock.yml | Updated environment lockfile snapshot for linux-64 (py3.12). |
| environments/py-3.12-linux-64-dev.conda.lock.yml | Updated dev environment lockfile snapshot for linux-64 (py3.12). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #476 +/- ##
========================================
Coverage 90.45% 90.46%
========================================
Files 113 113
Lines 6987 6993 +6
Branches 862 864 +2
========================================
+ Hits 6320 6326 +6
Misses 451 451
Partials 216 216
🚀 New features to boost your workflow:
|
gmcga
requested changes
Sep 1, 2026
gmcga
requested changes
Sep 4, 2026
Comment on lines
+478
to
+482
| else: | ||
| save_group = directives.SaveLPIterationsGroup( | ||
| driver.inversion_data.entity, | ||
| driver.directives.update_irls_directive, | ||
| components=directive.components, |
There was a problem hiding this comment.
should driver.directives.updated_irls_directive be self._directives.update_irls_directive as done above?
Collaborator
Author
There was a problem hiding this comment.
Yes, you are correct. The sub-directive would always stay L2...
# Conflicts: # environments/py-3.12-linux-64-dev.conda.lock.yml # environments/py-3.12-win-64-dev.conda.lock.yml # environments/py-3.13-linux-64-dev.conda.lock.yml # environments/py-3.13-win-64-dev.conda.lock.yml # py-3.12.conda-lock.yml # py-3.13.conda-lock.yml
GEOPY-3043: Create different data types for declination and inclination on the MVI models
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-3041 - Create Data groups for L2 and LP iterations on predicted data