improve some utils function and a bunch of tests

.gitignore

@@ -2,6 +2,7 @@
 .DS_Store
 node_modules
 dist
+coverage
 .idea
 yarn.lock
 

package.json

@@ -50,6 +50,8 @@
     "build": "rm -rf dist && bunchee",
     "build:umd": "bunchee --runtime browser --format umd --output dist/mixin-node-sdk.umd.js",
     "test": "vitest run",
+    "test:coverage": "vitest run --coverage",
+    "test:integration": "MIXIN_INTEGRATION_TESTS=1 vitest run",
     "test:watch": "vitest",
     "lint": "eslint 'src/**' && prettier --check .",
     "format": "prettier --write .",
@@ -82,6 +84,7 @@
     "@types/ws": "^8.18.1",
     "@typescript-eslint/eslint-plugin": "^8.69.0",
     "@typescript-eslint/parser": "^8.69.0",
+    "@vitest/coverage-v8": "^4.1.11",
     "buffer": "^6.0.3",
     "bunchee": "^6.12.2",
     "eslint": "^10.10.0",

src/client/circle.ts

@@ -28,19 +28,20 @@ export const CircleKeystoreClient = (axiosInstance: AxiosInstance) => ({
   delete: (circleID: string): Promise<any> => axiosInstance.post<unknown, any>(`/circles/${circleID}/delete`),
 
   /** Add the user to  a circle */
-  addUser: (userID: string, circleID: string): Promise<CircleResponse[]> => axiosInstance.post<unknown, CircleResponse[]>(`/users/${userID}/circles`, { circleID, action: 'ADD' }),
+  addUser: (userID: string, circleID: string): Promise<CircleResponse[]> =>
+    axiosInstance.post<unknown, CircleResponse[]>(`/users/${userID}/circles`, { circle_id: circleID, action: 'ADD' }),
 
   /** Remove the user from a circle */
   removeUser: (userID: string, circleID: string): Promise<CircleResponse[]> =>
-    axiosInstance.post<unknown, CircleResponse[]>(`/users/${userID}/circles`, { circleID, action: 'REMOVE' }),
+    axiosInstance.post<unknown, CircleResponse[]>(`/users/${userID}/circles`, { circle_id: circleID, action: 'REMOVE' }),
 
   /** Add the group from a certain circle */
   addConversation: (conversationID: string, circleID: string): Promise<CircleResponse[]> =>
-    axiosInstance.post<unknown, CircleResponse[]>(`/conversations/${conversationID}/circles`, { circleID, action: 'ADD' }),
+    axiosInstance.post<unknown, CircleResponse[]>(`/conversations/${conversationID}/circles`, { circle_id: circleID, action: 'ADD' }),
 
   /** Remove the group from a certain circle */
   removeConversation: (conversation_id: string, circleID: string): Promise<CircleResponse[]> =>
-    axiosInstance.post<unknown, CircleResponse[]>(`/conversations/${conversation_id}/circles`, { circleID, action: 'REMOVE' }),
+    axiosInstance.post<unknown, CircleResponse[]>(`/conversations/${conversation_id}/circles`, { circle_id: circleID, action: 'REMOVE' }),
 });
 
 export const CircleClient = buildClient(CircleKeystoreClient);

src/client/http.ts

@@ -9,8 +9,8 @@ import { ResponseError } from './error';
 import { signAccessToken } from './utils/auth';
 
 export function http(keystore?: Keystore, config?: RequestConfig): AxiosInstance {
-  const timeout = config?.timeout || 3000;
-  const retries = config?.retry || 5;
+  const timeout = config?.timeout ?? 3000;
+  const retries = config?.retry ?? 5;
 
   const ins = axios.create({
     baseURL: 'https://api.mixin.one',
@@ -32,7 +32,7 @@ export function http(keystore?: Keystore, config?: RequestConfig): AxiosInstance
       const requestID = uuid();
       config.headers['X-Request-Id'] = requestID;
       const jwtToken = signAccessToken(method, url, data, requestID, keystore);
-      config.headers.Authorization = `Bearer ${jwtToken}`;
+      if (jwtToken) config.headers.Authorization = `Bearer ${jwtToken}`;
     }
 
     return config;

src/client/types/mixin_transaction.ts

@@ -1,15 +1,17 @@
 export interface MintData {
   group: string;
   batch: bigint;
-  amount: number;
+  /** Use a decimal string for exact amounts. Decoding always returns a string. */
+  amount: string | number;
 }
 
 export interface DepositData {
   chain: string;
   asset: string;
   transaction: string;
   index: bigint;
-  amount: number;
+  /** Use a decimal string for exact amounts. Decoding always returns a string. */
+  amount: string | number;
 }
 
 export interface WithdrawData {

src/client/types/nfo.ts

@@ -6,6 +6,7 @@ export interface NFOMemo {
   chain?: string /** chain uuid */;
   class?: string /** contract address */;
   collection?: string /** collection uuid */;
-  token?: number;
+  /** Exact token ID as a decimal integer string. */
+  token?: string;
   extra: string;
 }

src/client/utils/address.ts

@@ -101,7 +101,7 @@ export const getMixAddressBuffer = (ma: MixAddress) => {
   if (members.length > 255) {
     throw new Error(`invalid members length: ${members.length}`);
   }
-  if (ma.threshold === 0 || ma.threshold > members.length) {
+  if (!Number.isInteger(ma.threshold) || ma.threshold < 1 || ma.threshold > members.length) {
     throw new Error(`invalid threshold: ${ma.threshold}`);
   }