Remove the flag that lets a run report skips as acceptable - #136
Merged
estebanzimanyi merged 1 commit intoSep 7, 2026
Merged
Conversation
`--allow-skips` made the rule conditional: a repository passing it reported success over a suite that asserted nothing, and the summary line said so in words that read like a pass. No workflow in the ecosystem passes it — a code search over MEOS-API, GoMEOS, JMEOS, MobilityAPI, MobilityFlink, MobilitySpark, MobilityKafka, MobilityDuck and PyMEOS finds the flag only in this file's own definition, and the composite action never exposed it — so it stands as an escape hatch and nothing else. The parser now rejects it: `unrecognized arguments: --allow-skips`. The command line moves into `build_parser` so the suite can read its options, and two tests keep the hatch shut. One asserts that no option carries `skip` or `ignore` in its name, against a positive control that `--min-tests` is there, so the assertion cannot pass over a parser it failed to build. The other reads a vstest summary carrying one skip and holds that the count reaches the caller whatever the floor says. 18 tests pass. Against a real `dotnet test` log the tool exits 0 on a clean run, 1 on a summary carrying `Skipped: 1`, 1 on a floor above the total, and 2 on the removed flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--allow-skipsmade the rule conditional: a repository passing it reportedsuccess over a suite that asserted nothing, and the summary line said so in
words that read like a pass. No workflow in the ecosystem passes it — a code
search over MEOS-API, GoMEOS, JMEOS, MobilityAPI, MobilityFlink, MobilitySpark,
MobilityKafka, MobilityDuck and PyMEOS finds the flag only in this file's own
definition, and the composite action never exposed it — so it stands as an
escape hatch and nothing else. The parser now rejects it:
unrecognized arguments: --allow-skips.The command line moves into
build_parserso the suite can read its options,and two tests keep the hatch shut. One asserts that no option carries
skiporignorein its name, against a positive control that--min-testsis there, sothe assertion cannot pass over a parser it failed to build. The other reads a
vstest summary carrying one skip and holds that the count reaches the caller
whatever the floor says.
18 tests pass. Against a real
dotnet testlog the tool exits 0 on a clean run,1 on a summary carrying
Skipped: 1, 1 on a floor above the total, and 2 on theremoved flag.