Read the value bounds of a temporal number in its base type - #139
Merged
estebanzimanyi merged 1 commit intoSep 10, 2026
Merged
Conversation
The `vspan` covering holds the value bounds of a temporal number in its base type, read off the value: `tint_min_value`/`tint_max_value` as int, `tbigint_min_value`/`tbigint_max_value` as bigint, and `tfloat_min_value`/`tfloat_max_value` as double. A bigint bound stays exact above 2^53 and no bound is rounded inward, so the covering stays conservative and pruning never skips a matching row. The three number types differ in base type, so a covering gives its fields per type (`byType`) where they differ and once for the class (`fields`) where they do not. The parser resolves them into the fields of each type and requires a per-type covering to name exactly the types of its class. The descriptor schema admits `bigint` as a field type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
vspancovering holds the value bounds of a temporal number in itsbase type, read off the value:
tint_min_value/tint_max_valueas int,tbigint_min_value/tbigint_max_valueas bigint, andtfloat_min_value/tfloat_max_valueas double. A bigint bound staysexact above 2^53 and no bound is rounded inward, so the covering stays
conservative and pruning never skips a matching row.
The three number types differ in base type, so a covering gives its
fields per type (
byType) where they differ and once for the class(
fields) where they do not. The parser resolves them into the fields ofeach type and requires a per-type covering to name exactly the types of its
class. The descriptor schema admits
bigintas a field type.