Conversation
cka-y
marked this pull request as ready for review
August 6, 2026 16:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1775
Creates the architecture to extract file content from GTFS files, plus the first extractor:
feed_info.txt. A newgtfs-file-data-extractorfunction receives one file per invocation and delegates to an extractor resolved by file name, so supporting a new file means adding aFileDataExtractorsubclass, registering it inextractors/registry.py, and adding the file name toEXTRACTABLE_FILESinpipeline_tasks.py.Adds a
feedinfotable (one row per dataset, FK togtfsdatasetwith cascade delete). Additive only — no API spec or existing column changes.Expected behavior:
After the daily batch processing (
batch-process-dataset), we have a list of files registered for content extraction. For each file we trigger the extraction providing the file url and dataset and feed information. The data is extracted and saved to the database.Tasks are only enqueued for files whose content changed since the previous dataset, and extraction upserts on the dataset, so reprocessing updates in place instead of duplicating.
Testing tips:
Function can be tested by running the batch processing function or by calling the newly created
gtfs-file-data-extractorfunction directly through HTTP after building this branch on DEV/QA. E.g. of running it in QA:Note for deploying:
api-deployercreates the function,datasets-batch-deployercreates the task queue. Runapi-deployerfirst, otherwise tasks are enqueued against a function that doesn't exist yet.Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything