fix: quarantine PD pages until transfer quiesces - #1406
Open
sufubao wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
sufubao
force-pushed
the
fix/pd-nixl-page-release-order
branch
from
July 27, 2026 09:49
85f2774 to
6508d71
Compare
sufubao
force-pushed
the
fix/pd-nixl-page-release-order
branch
from
July 27, 2026 10:02
6508d71 to
c4e01ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIXL WRITE 超时后不再立即回收传输页。Prefill 保留 source page 和 handle,继续轮询到 DONE/ERR,释放 handle 后向 Decode 返回 quiesced 状态;Decode 在此之前将 destination page 留在 quarantine,收到 quiesced error 或晚到 DONE 后再回收。
这样不会因为请求已经返回失败而复用仍可能被旧传输访问的页面。若传输永久停留在 PROC,页面会继续隔离。
验证:PD transfer lifecycle 单测 5/5 通过,Black、Flake8、compileall 和 git diff --check 通过。未运行双节点 NIXL 集群测试。