Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hypercorn daemon workers cannot start multiprocessing children, so ConfigServer TCPStore creation fails. Launch the store with a subprocess, monitor its original parent and reap it before replacement. Skip the local NCCL-port check when ConfigServer owns the store, allowing rank-zero restart.
Validation on main 9640f76: 51 CPU tests pass. With the image's Hypercorn 0.18, unmodified main returns HTTP 500; the fix passes initial creation and same-port replacement with real TCPStore roundtrips, and leaves no store child after Hypercorn exits.