Remove Deprecated From ItemWithRenderer and Actually Implement - #269
Merged
Conversation
Member
Author
|
I'm going to gloss over the fact that you also overwrite classes and paste the entire old class content into your own for absolutely no reason at all. |
Contributor
|
if it helps test compatibility, we use it in good-flags |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mine, this interface is so half baked I'm astonished if anyone actually ever used this.
Also don't deprecate shit we don't have a replacement for kthanksbye.
Here it is with some half baked assumptions made to not break backwards compat. You're welcome.
Details
MFW mine does something inexplicable and gives and even more inexplicable reason
