Add silence-based stop for audio sync transmission - #11
Open
netmindz wants to merge 1 commit into
Open
Conversation
Collaborator
|
@netmindz looks good 👍 |
There was a problem hiding this comment.
🟡 Changes recommended
Silence state persists across mode transitions, and unsupported devices receive a nonfunctional setting.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds configurable silence-based suspension of UDP audio synchronization.
Changes:
- Tracks continuous sender silence and stops packets after 30 seconds.
- Persists and exposes the setting in the UI.
File summaries
| File | Description |
|---|---|
audio_reactive.h |
Implements silence tracking, transmission gating, configuration, and UI. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2439
to
+2442
| if (audioSyncEnabled & AUDIOSYNC_SEND) { | ||
| if (volumeSmth >= 1.0f) syncSilenceStart = 0; // sound detected - clear silence timer | ||
| else if (syncSilenceStart == 0) syncSilenceStart = millis(); // just went silent - start timer | ||
| } |
Comment on lines
+3218
to
+3222
| // silence_stop: Sender stops transmitting UDP packets after 30s of continuous silence | ||
| oappend(SET_F("dd=addDropdown(ux,'sync:silence_stop');")); | ||
| oappend(SET_F("addOption(dd,'Off',0);")); | ||
| oappend(SET_F("addOption(dd,'On',1);")); | ||
| oappend(SET_F("addInfo(ux+':sync:silence_stop',1,'<i>stop sending after 30s silence</i> ☾<br> Sync audio data with other WLEDs');")); // must append this to the last field of 'sync' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new feature to the audio synchronization system: the ability for the sender to automatically stop transmitting UDP audio sync packets after 30 seconds of continuous silence. This is configurable and exposed in the sync settings. The implementation tracks silence duration and skips transmission when appropriate, and the new setting is included in both the configuration and the user interface.
This very useful when you have one (or more) line-in setups combined with devices with their own mic set to "receive or local"
Audio sync silence stop feature:
audioSyncSilenceStopto control whether the sender should stop transmitting UDP packets after 30 seconds of silence.syncSilenceStartvariable to track when continuous silence begins on the sender.Configuration and UI updates:
silence_stopparameter in the sync configuration JSON for both saving and loading settings. [1] [2]