Add generic usermod palette support, move AR palettes to usermod #373
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -986,20 +986,38 @@ function populatePalettes() | |
| ); | ||
| } | ||
| gId('pallist').innerHTML=html; | ||
| // append usermod palettes (fixed ID space: 255 down to 201) | ||
| let li = lastinfo; | ||
| if (!isEmpty(li) && li.umpalcount && li.umpalnames) { | ||
| for (let j = 0; j < li.umpalcount; j++) { | ||
| let div = d.createElement("div"); | ||
| gId('pallist').appendChild(div); | ||
| div.outerHTML = generateListItemHtml( | ||
| 'palette', | ||
| 255-j, | ||
| li.umpalnames[j], | ||
|
There was a problem hiding this comment. 🔒 Security & Privacy | 🛡️ Analyzed with Security Review | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- relevant definitions and callers ---'
rg -n -C 8 'generateListItemHtml|umpalnames|outerHTML' wled00/data/index.js
printf '%s\n' '--- source range around the reported line ---'
sed -n '960,1015p' wled00/data/index.jsRepository: MoonModules/WLED-MM Length of output: 4844 🏁 Script executed: #!/bin/bash
set -eu
rg -n -C 6 'lastinfo\s*=|lastinfo\.|requestJson|json|info' wled00/data/index.js wled00/data/simple.js | head -240Repository: MoonModules/WLED-MM Length of output: 12119 🏁 Script executed: #!/bin/bash
set -eu
rg -n -C 8 'lastinfo' wled00/dataRepository: MoonModules/WLED-MM Length of output: 34861 XSS Reachability: External Encode fetched usermod palette names before HTML insertion.
🧰 Tools🪛 ast-grep (0.45.3)[warning] 994-1000: Avoid assigning untrusted data to innerHTML/outerHTML or document.write (inner-outer-html) 🤖 Prompt for AI AgentsSources: Path instructions, Linters/SAST tools |
||
| 'setPalette', | ||
| `<div class="lstIprev" style="${genPalPrevCss(255-j)}"></div>` | ||
| ); | ||
| } | ||
| } | ||
| // append user custom palettes (fixed ID space: 200 down to FIXED_PALETTE_COUNT+1) | ||
| if (!isEmpty(li) && li.cpalcount) { | ||
| for (let j = 0; j < li.cpalcount; j++) { | ||
| const id = 200 - j; | ||
| const pd = palettesData[id]; | ||
| if (pd && pd.length === 16 && pd.every(e => e[1] === 128 && e[2] === 128 && e[3] === 128)) continue; // skip gray gap-placeholder entries | ||
| let div = d.createElement("div"); | ||
| gId('pallist').appendChild(div); | ||
| div.outerHTML = generateListItemHtml( | ||
| 'palette', | ||
| id, | ||
| '~ Custom '+j+' ~', | ||
| 'setPalette', | ||
| `<div class="lstIprev" style="${genPalPrevCss(id)}"></div>` | ||
| ); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| function redrawPalPrev() | ||
|
|
@@ -3449,7 +3467,7 @@ function loadPalettesData(callback = null) | |
| if (lsPalData) { | ||
| try { | ||
| var d = JSON.parse(lsPalData); | ||
| if (d && d.vid == lastinfo.vid && d.pcount == lastinfo.palcount) { // WLEDMM: also invalidate cache if total palette count changed (fixes upstream bug where vid alone was compared to itself) | ||
| palettesData = d.p; | ||
| if (callback) callback(); | ||
| return; | ||
|
|
@@ -3461,8 +3479,10 @@ function loadPalettesData(callback = null) | |
| getPalettesData(0, ()=>{ | ||
| localStorage.setItem(lsKey, JSON.stringify({ | ||
| p: palettesData, | ||
| vid: lastinfo.vid, | ||
| pcount: lastinfo.palcount // WLEDMM: total palette count, used to invalidate stale cache | ||
| })); | ||
|
|
||
| redrawPalPrev(); | ||
| if (callback) setTimeout(callback, 99); | ||
| }); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add a source URL for the upstream attribution.
The comments reference upstream WLED PR
#5548but do not include a GitHub or documentation link.wled00/colors.h#L79-L81: add the specific upstream source URL.wled00/colors.cpp#L508-L509: add the same specific upstream source URL.As per coding guidelines, “Document attribution of inspiration, knowledge, and sources used in code with links to GitHub repositories or documentation.”
📍 Affects 2 files
wled00/colors.h#L79-L81(this comment)wled00/colors.cpp#L508-L509🤖 Prompt for AI Agents
Source: Coding guidelines