Skip to content

fix: make store-based barrier reusable across updates - #107

Open
RunningLeon wants to merge 1 commit into
MoonshotAI:mainfrom
RunningLeon:fix/reusable-store-barrier
Open

fix: make store-based barrier reusable across updates#107
RunningLeon wants to merge 1 commit into
MoonshotAI:mainfrom
RunningLeon:fix/reusable-store-barrier

Conversation

@RunningLeon

Copy link
Copy Markdown

fix: make the shared-store barrier reusable across updates in #106

Summary

  • add an independent generation counter for ParameterServer.store_based_barrier();
  • use a unique _store_based_barrier() group name for every invocation;
  • keep the long-lived root TCPStore unchanged and shared;
  • add CPU-only regression coverage for two consecutive barriers on the same TCPStore.

@koriyoshi2041 koriyoshi2041 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the repeated-barrier path on the exact head. The generation counter is independent of process-group creation, every rank deterministically advances it once per successful update barrier (including auto_pg=False), and the shared-store regression exercises two consecutive generations. Locally, tests/test_store_barrier.py passes 2/2; focused Ruff check/format and diff hygiene also pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants