fix(reporter): Discord/GitHub-issue/forum buttons silently did nothing

[soloturn]

AI-assisted change proposal. Filed by agent driven by @soloturn via GDD.

Summary

Found while manually clicking the "Join Discord Server" / "File an issue on GitHub" / forum buttons in the reporter dialog: nothing visibly happened.

Root cause: GlobalProperties.get() returns null for JOIN_DISCORD_LINK/REPORT_ISSUE_LINK/SUPPORT_FORUM_LINK whenever a downstream app doesn't configure them - cr-core's own defaults never set these, since they're app-specific. The old openInBrowser(String url) passed that straight into new URI(null), which throws NullPointerException - not one of the two checked exceptions the old code caught (IOException, URISyntaxException) - so it propagated out of the button's ActionListener uncaught on the EDT: silently swallowed, no popup, no trace anywhere the click happened.

Fix:

• New BrowserLauncher.open() replaces the two duplicate openInBrowser copies (FinalActionsPanel, UploadPanel) with one implementation that never throws: a missing/blank url, an invalid URI, or Desktop.browse itself failing are all caught and reported the same way uploadFailed() reports PasteBin failures - printed to stderr and shown in a JOptionPane - instead of disappearing.
• cr-core's own defaults now set REPORT_ISSUE_LINK to CrashReporter's own issue tracker and JOIN_DISCORD_LINK to Terasology's Discord (which CrashReporter shares), so a standalone cr-core (like the interactive test) has somewhere real to go rather than nothing. Downstream apps that need something different (e.g. cr-destsol's own issue tracker) already override these.

Test plan

• New BrowserLauncherTest - drives the null/blank/invalid-URI/browser-throws cases via an injected Consumer<URI> seam, no real Desktop or popup needed.
• ./gradlew build - clean.

Related

• Found while manually testing fix(reporter): include every log file in the PasteBin upload #56/fix(reporter): pre-fill the GitHub issue form with a crash summary #58/fix(reporter): sort log tabs alphabetically instead of by creation time #59/fix(reporter): remove the "Go to Forum" button and link #60/build: seed runInteractiveTest with real log fixtures automatically #61/build: bump mockito-core to 5.23.0 for JDK 26 support #62/fix(reporter): degrade to the placeholder image when a resource property is unset #63/fix(reporter): time out a PasteBin upload instead of hanging forever #64/fix(reporter): fix PasteBin upload (missing Jackson dep) and always log upload failures #65 together via merge-train.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 765e6287-cdb4-4004-8ac2-24a337f27c0a

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}