Repository navigation
Move KSP/Unity handling out of RCSSolver - #2335
Merged
Merged
Conversation
This is some prep for moving RCSSolver into MechJebLib. Primarily motivated by making the MechJebModuleRCSBalancer class responsible for managing the RCSModule directly and not having the save/restore thrust functionality down in the RCSSolver. The Thruster class in RCSSolver then loses references to gameObjects which decouples the BLIEC solver problem from KSP/Unity. The fact that the thread runner around the problem was being called in order to reset the part modules is a violation of separation of concerns. Writing this call is just bad: solverThread.ResetThrusterForces() Why is the thing you call to reset the RCSModules (executing in your own thread) the same thing you call which babysits the thread for the math problem? Also hoists CheckVessel() up out of the solverThread. This maybe pushes too much work back up into the MJModule, but that probably needs to get broken apart there and not just pushed into the math problem and thread wrapper around it to try to hide it. Plus a bunch of fallout and two bugfixes: - Fixes the TODO around using stale state - Fixes restoring thruster state in OnModuleDisabled
Contributor
✅ Build Artifact 🚀MechJeb2-6172f3d.zip (built from 522d50e) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is some prep for moving RCSSolver into MechJebLib.
Primarily motivated by making the MechJebModuleRCSBalancer class responsible for managing the ModuleRCS directly and not having the save/restore thrust functionality down in the RCSSolver.
The Thruster class in RCSSolver then loses references to gameObjects which decouples the BLIEC solver problem from KSP/Unity.
The fact that the thread runner around the problem was being called in order to reset the part modules is a violation of separation of concerns. Writing this call is just bad:
solverThread.ResetThrusterForces()
Why is the thing you call to reset the ModuleRCS (executing in your own thread) the same thing you call which babysits the thread for the math problem?
Also hoists CheckVessel() up out of the solverThread.
This maybe pushes too much work back up into the MJModule, but that probably needs to get broken apart there and not just pushed into the math problem and thread wrapper around it to try to hide it.
Plus a bunch of fallout and two bugfixes: