Skip to content

Engine train 7: a profile's SOCKS5 proxy, with its password stored - #223

Merged
vadi2 merged 2 commits into
mainfrom
ccr-14671218-tf96z6-train7
Nov 19, 2026
Merged

vadi2 merged 2 commits into
mainfrom
ccr-14671218-tf96z6-train7

Conversation

@vadi2

@vadi2 vadi2 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Brief overview of PR changes/additions

  • A profile's editor gains desktop's proxy settings: use a SOCKS5 proxy, its address, port, user name and password.
  • The proxy is Mudlet's setting, read and changed while the game is open; a refusal shows Mudlet's reason.
  • The proxy's password is kept in PasswordStore beside the game's and reaches the engine only with openProfile, for the run. Patch 0042 keeps a password given that way out of Mudlet's credential store and the profile's file.
  • Protocol 47: getProxy, setProxy, proxy, and proxyPassword in openProfile.
  • A copied profile gets the proxy but not its password, as on desktop.

Motivation for adding to Mudlet

Players on a network that only lets traffic out through a SOCKS5 proxy reach their game on desktop but not on Android (IF5).

Other info (issues closed, discussion etc)

Part of Mudlet/Mudlet#9011. Engine train 7, rebase-merge so each car stays its own commit.

🤖 Generated with Claude Code

https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J

@vadi2
vadi2 force-pushed the ccr-14671218-tf96z6-train7 branch 6 times, most recently from cf3df99 to d460676 Compare November 19, 2026 15:56
- getProxy and setProxy read and change the open profile's proxy as desktop Mudlet's Connection preferences hold
  it (use, host, port, user), kept with the profile from its next connection; openProfile's proxyPassword gives the
  proxy's password for this run only, as password gives the game's, and nothing stores or sends it back.
- Mudlet patch 0042-headless-proxy: THeadlessSession::proxy(), setProxy(),
  setProxyPassword() and Options::proxyPassword; a password given for the run is not stored or written to the
  profile's file, and a user name or password removed is no longer sent.
- Protocol 47: docs/protocol.md, SocketBridge, ControlBridge, Protocol.kt and protocol_client.py.
- Host test running_profile_proxy through native/tests/fake_socks5.py, a SOCKS5 proxy on 127.0.0.1 that connects
  only to this machine: with a user name and password, the wrong one, one withdrawn, one given as the profile
  starts, a proxy that refuses, the proxy kept but not used, setProxy's refusals and the profile's file.

Part of Mudlet/Mudlet#9011

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
…ord stored

The profile editor gains desktop Mudlet's "Connect to the game via proxy":
use a proxy, its address, port and user name, read from and changed in Mudlet
while the game is open (getProxy, setProxy), as desktop's profile preferences
are. The proxy's password is stored in PasswordStore beside the game's, under
"proxy:" before the profile's name, and goes to the engine only in openProfile,
which now always carries both passwords.

Part of Mudlet/Mudlet#9011

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
@vadi2
vadi2 force-pushed the ccr-14671218-tf96z6-train7 branch from d460676 to 733736b Compare November 19, 2026 16:13
@vadi2
vadi2 merged commit 631a46f into main Nov 19, 2026
23 checks passed
@vadi2
vadi2 deleted the ccr-14671218-tf96z6-train7 branch November 19, 2026 16:43
vadi2 pushed a commit that referenced this pull request Nov 19, 2026
The status table's rows for what merged since #220: opening a shared .zip
with Mudlet finishes lane 3 (#224), and the SOCKS5 proxy (engine train 7,
#223) finishes IF5. Also in: a selection across lines (#225), a profile's
log files shared or opened (#222), patch 0004 rebased on
Mudlet/Mudlet#12937 (engine train 8, #228) and the corner map's controls
behind a button (#227).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
vadi2 added a commit that referenced this pull request Nov 19, 2026
docs/plan.md's status table brought up to date with today's merges: IF3 (#228, patch 0004), IF5 done (#223, a profile's SOCKS5 proxy), IF6 (#222, a profile's log files), 3 done (#224, open a shared .zip with Mudlet), 6 (#225, a selection across lines) and 10 (#227, a corner map's controls behind a button). Existing rows changed in place; none added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants