Skip to content

Engine train 8: patch 0004 rebased on Mudlet's #12937 - #228

Merged
vadi2 merged 1 commit into
mainfrom
ccr-14671218-tf96z6-patch-0004
Nov 19, 2026
Merged

vadi2 merged 1 commit into
mainfrom
ccr-14671218-tf96z6-patch-0004

Conversation

@vadi2

@vadi2 vadi2 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Brief overview of PR changes/additions

  • Patch 0004 applies to Mudlet's development again, so CI and the PTB build the engine (red on Show a small map's controls only on request, behind a button in the map #227 since upstream merged Improve: Screen readers keep up with fast-changing labels Mudlet#12937, e3b91ac).
  • #12937 made TLabelModel::setLiveRegion() tell the view of a change (AccessibilityChange::LiveRegion), over the lines 0004 changed. 0004 drops its TLabel/TLabelModel hunks and keeps what Mudlet still lacks: LabelContent::liveRegion, its fill, its HeadlessSessionWindowsTest case, its docs/headless.md line and a comment.
  • docs/phase-f.md (gap 3 and its interim note) says what Mudlet now does.
  • No behaviour change for players: TalkBack still reads a label's live region as before.

Motivation for adding to Mudlet

Every engine build against Mudlet's development stopped at apply-mudlet-patches.sh; main breaks the same way on its next run.

Other info (issues closed, discussion etc)

Part of Mudlet/Mudlet#9011
No new test: no behaviour added. The existing HeadlessSessionWindowsTest, the host engine's labels test (a live region alone resends the label) and the app's live-region tests cover it.
Checked: patches 0001-0042 apply in order (and re-apply) on a fresh Mudlet development d7fb1f0; syntax-only compile of the patched THeadlessSessionWindows.cpp and test; scripts/lint.sh parts that run here (vendored, clang-format, shellcheck, actionlint, strings, ...). No host build locally (no Qt 6.8 here): CI's desktop-engine job is it.
CI (on main 631a46f): https://github.com/Mudlet/android/actions/runs/44590358061 green; PTB (dispatched, the PR's paths do not start it): https://github.com/Mudlet/android/actions/runs/44590502565 green; device-only: none.
Size: ptb-arm64-v8a 82.13 MB (dex 4.05 MB), aab 114.59 MB (dex 1.98 MB), within budget.

🤖 Generated with Claude Code

https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J

Mudlet/Mudlet#12937 (e3b91ac) made TLabelModel::setLiveRegion() tell the view of a change through
AccessibilityChange::LiveRegion, which TLabel handles itself, over the lines patch 0004 changed, so 0004
no longer applied to Mudlet's development. The patch keeps only what Mudlet still lacks: liveRegion in
THeadlessSession::LabelContent, its test in HeadlessSessionWindowsTest, its docs/headless.md line and
TNullConsoleFrontend's comment. docs/phase-f.md's gap 3 says what Mudlet now does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
@vadi2
vadi2 merged commit eb66030 into main Nov 19, 2026
21 checks passed
@vadi2
vadi2 deleted the ccr-14671218-tf96z6-patch-0004 branch November 19, 2026 19:19
vadi2 pushed a commit that referenced this pull request Nov 19, 2026
The status table's rows for what merged since #220: opening a shared .zip
with Mudlet finishes lane 3 (#224), and the SOCKS5 proxy (engine train 7,
#223) finishes IF5. Also in: a selection across lines (#225), a profile's
log files shared or opened (#222), patch 0004 rebased on
Mudlet/Mudlet#12937 (engine train 8, #228) and the corner map's controls
behind a button (#227).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
vadi2 added a commit that referenced this pull request Nov 19, 2026
docs/plan.md's status table brought up to date with today's merges: IF3 (#228, patch 0004), IF5 done (#223, a profile's SOCKS5 proxy), IF6 (#222, a profile's log files), 3 done (#224, open a shared .zip with Mudlet), 6 (#225, a selection across lines) and 10 (#227, a corner map's controls behind a button). Existing rows changed in place; none added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants