Repository navigation
Engine train 8: patch 0004 rebased on Mudlet's #12937 - #228
Merged
Merged
Conversation
Mudlet/Mudlet#12937 (e3b91ac) made TLabelModel::setLiveRegion() tell the view of a change through AccessibilityChange::LiveRegion, which TLabel handles itself, over the lines patch 0004 changed, so 0004 no longer applied to Mudlet's development. The patch keeps only what Mudlet still lacks: liveRegion in THeadlessSession::LabelContent, its test in HeadlessSessionWindowsTest, its docs/headless.md line and TNullConsoleFrontend's comment. docs/phase-f.md's gap 3 says what Mudlet now does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
vadi2
pushed a commit
that referenced
this pull request
Nov 19, 2026
The status table's rows for what merged since #220: opening a shared .zip with Mudlet finishes lane 3 (#224), and the SOCKS5 proxy (engine train 7, #223) finishes IF5. Also in: a selection across lines (#225), a profile's log files shared or opened (#222), patch 0004 rebased on Mudlet/Mudlet#12937 (engine train 8, #228) and the corner map's controls behind a button (#227). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
vadi2
added a commit
that referenced
this pull request
Nov 19, 2026
docs/plan.md's status table brought up to date with today's merges: IF3 (#228, patch 0004), IF5 done (#223, a profile's SOCKS5 proxy), IF6 (#222, a profile's log files), 3 done (#224, open a shared .zip with Mudlet), 6 (#225, a selection across lines) and 10 (#227, a corner map's controls behind a button). Existing rows changed in place; none added. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
developmentagain, so CI and the PTB build the engine (red on Show a small map's controls only on request, behind a button in the map #227 since upstream merged Improve: Screen readers keep up with fast-changing labels Mudlet#12937, e3b91ac).TLabelModel::setLiveRegion()tell the view of a change (AccessibilityChange::LiveRegion), over the lines 0004 changed. 0004 drops itsTLabel/TLabelModelhunks and keeps what Mudlet still lacks:LabelContent::liveRegion, its fill, itsHeadlessSessionWindowsTestcase, itsdocs/headless.mdline and a comment.docs/phase-f.md(gap 3 and its interim note) says what Mudlet now does.Motivation for adding to Mudlet
Every engine build against Mudlet's
developmentstopped atapply-mudlet-patches.sh; main breaks the same way on its next run.Other info (issues closed, discussion etc)
Part of Mudlet/Mudlet#9011
No new test: no behaviour added. The existing
HeadlessSessionWindowsTest, the host engine's labels test (a live region alone resends the label) and the app's live-region tests cover it.Checked: patches 0001-0042 apply in order (and re-apply) on a fresh Mudlet
developmentd7fb1f0; syntax-only compile of the patchedTHeadlessSessionWindows.cppand test;scripts/lint.shparts that run here (vendored, clang-format, shellcheck, actionlint, strings, ...). No host build locally (no Qt 6.8 here): CI's desktop-engine job is it.CI (on main 631a46f): https://github.com/Mudlet/android/actions/runs/44590358061 green; PTB (dispatched, the PR's paths do not start it): https://github.com/Mudlet/android/actions/runs/44590502565 green; device-only: none.
Size: ptb-arm64-v8a 82.13 MB (dex 4.05 MB), aab 114.59 MB (dex 1.98 MB), within budget.
🤖 Generated with Claude Code
https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J