Publish usable root free percent from each pressure observer - #394
Merged
Conversation
The fleet observer runs only on gha-services. Switching compute_root_disk_low to gha_fleet_host_root_free_percent without a per-member publisher would have watched the control-plane host and gone blind to the four compute members whose 200 GiB loop file is the false signal. Clustered admission already reads the Incus pool; the live ticket stays on the OTel filesystem ratio until these series exist on every member.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#393 switched
compute_root_disk_lowtogha_fleet_host_root_free_percentand applied the loop-file exclusion in the central fleet observer. That process runs only ongha-services. Live OpenObserve currently has a single series for that family:host_name=gha-servicesat 76% free.The false tickets were on
gha-runner-1..4, whose 200 GiB Incus loop file is counted as used space by OTelsystem_filesystem_usage. Live free ratios are still 22.7–24.1% on those members (threshold 20%). Applying the #393 rule as-is would have made the ticket watch the control-plane host and go blind to the compute members.OOM already works per member because
gha-pressure-observeron:9471publishesgha_fleet_host_oom_kills_total. Disk belongs in the same process.What
hostdisk.Observestats root and subtracts allocated loop-backed pool files on the same device.gha_fleet_host_root_free_percent(0 on stat error, fail closed).Do not reconcile OpenObserve onto the new expression until all four members publish the series.
Proof
go test ./internal/hostdisk ./internal/pressureobserve ./internal/observabilityrules