IRMER authorisation – change content on medical info button - #401
Open
rivalee wants to merge 5 commits into
Open
IRMER authorisation – change content on medical info button#401rivalee wants to merge 5 commits into
rivalee wants to merge 5 commits into
Conversation
edwardhorsford
temporarily deployed
to
manage-breas-irmer-auth-qtduvv
August 10, 2026 12:53
Inactive
edwardhorsford
temporarily deployed
to
manage-breas-irmer-auth-qtduvv
August 10, 2026 13:56
Inactive
edwardhorsford
temporarily deployed
to
manage-breas-irmer-auth-qtduvv
August 12, 2026 09:55
Inactive
rivalee
marked this pull request as ready for review
August 18, 2026 13:55
| updateProgress(sections, completedSections) | ||
|
|
||
| // Handle "Complete all and continue" button | ||
| // Handle "Authorise" button |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Handle "Authorise" button | |
| // Handle "Complete all and continue" button |
| function highlightCompletionButton() { | ||
| const completeButton = document.querySelector( | ||
| 'button:contains("Complete all and continue")' | ||
| 'button:contains("Authorise")' |
Collaborator
There was a problem hiding this comment.
Suggested change
| 'button:contains("Authorise")' | |
| 'button:contains("Complete all and continue")' |
Collaborator
There was a problem hiding this comment.
We still need to inform users of what happens when clicking this button - switching to 'Authorise' removes this, creating risk they would skip some of the medical info steps.
For qualified users, we should include copy associated to the button rather than changing the button itself
|
|
||
| buttons.forEach((btn) => { | ||
| if (btn.textContent.includes('Complete all and continue')) { | ||
| if (btn.textContent.includes('Authorise')) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (btn.textContent.includes('Authorise')) { | |
| if (btn.textContent.includes('Complete all and continue')) { |
|
|
||
| await page | ||
| .getByRole('button', { name: 'Complete all and continue' }) | ||
| .getByRole('button', { name: 'Authorise' }) |
Collaborator
There was a problem hiding this comment.
Suggested change
| .getByRole('button', { name: 'Authorise' }) | |
| .getByRole('button', { name: 'Complete all and continue' }) |
| ).toBeVisible() | ||
| await page | ||
| .getByRole('button', { name: 'Complete all and continue' }) | ||
| .getByRole('button', { name: 'Authorise' }) |
Collaborator
There was a problem hiding this comment.
Suggested change
| .getByRole('button', { name: 'Authorise' }) | |
| .getByRole('button', { name: 'Complete all and continue' }) |
| </div> | ||
| {% else %} | ||
| {{ button({ | ||
| text: "Authorise and continue", |
Collaborator
There was a problem hiding this comment.
Suggested change
| text: "Authorise and continue", | |
| text: "Complete all and continue", |
| text: "Authorise and continue", | ||
| classes: "js-complete-all-sections nhsuk-u-margin-bottom-0" | ||
| }) }} | ||
| <p class="nhsuk-body-s nhsuk-u-secondary-text-color nhsuk-u-margin-top-2 nhsuk-u-margin-bottom-5">This will authorise imaging by {{ data.currentUser.firstName }} {{ data.currentUser.lastName }}</p> |
Collaborator
There was a problem hiding this comment.
Suggested change
| <p class="nhsuk-body-s nhsuk-u-secondary-text-color nhsuk-u-margin-top-2 nhsuk-u-margin-bottom-5">This will authorise imaging by {{ data.currentUser.firstName }} {{ data.currentUser.lastName }}</p> | |
| <p class="nhsuk-body-s nhsuk-u-secondary-text-color nhsuk-u-margin-top-2 nhsuk-u-margin-bottom-5">By continuing, you ({{ data.currentUser.firstName }} {{ data.currentUser.lastName }}) are authorising images to be taken</p> |
| name: "irmerAuthoriser", | ||
| fieldset: { | ||
| legend: { | ||
| text: "Select an authoriser" |
Collaborator
There was a problem hiding this comment.
Suggested change
| text: "Select an authoriser" | |
| text: "Who is authorising that images can be taken for this appointment?" |
|
|
||
| {{ appModal({ | ||
| id: "choose-authoriser-modal", | ||
| title: "Choose an authoriser", |
Collaborator
There was a problem hiding this comment.
Suggested change
| title: "Choose an authoriser", | |
| title: "Nominate a mammographer", |
| const selected = modal.querySelector("input[name='irmerAuthoriser']:checked") | ||
| if (selected) { | ||
| document.querySelectorAll(".js-irmer-authorise-button").forEach((btn) => { | ||
| btn.textContent = "Authorise with " + selected.value + " and continue" |
Collaborator
There was a problem hiding this comment.
Suggested change
| btn.textContent = "Authorise with " + selected.value + " and continue" | |
| btn.textContent = "Complete all and continue" |
| legend: { | ||
| text: "Select an authoriser" | ||
| } | ||
| }, |
Collaborator
There was a problem hiding this comment.
Suggested change
| }, | |
| }, | |
| hint: { | |
| text: "The person selected must be present while images are being taken" | |
| }, |
Collaborator
There was a problem hiding this comment.
Hint text below the question clarifying the role of the person being picked
| btn.classList.add("js-complete-all-sections") | ||
| btn.classList.remove("js-choose-authoriser-link") | ||
| }) | ||
| // Show the alternative authoriser links |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Show the alternative authoriser links | |
| document.querySelectorAll(".js-authoriser-confirmation").forEach((p) => { | |
| p.textContent = `By continuing, ${selected.value} is authorising images to be taken`; | |
| }); | |
| // Show the alternative authoriser links |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the content on the medical information page to cover IRMER authorisation, both for when the mammographer has permission to authorise, and when they need to sign the authorisation with another mammographer's name.
When the mammographer has permission to authorise imaging
When the mammographer doesn't have permission and needs to authorise using another's name