Skip to content

CCM-24467: Mise Compatibility - #342

Open
jamesthompson26-nhs wants to merge 6 commits into
mainfrom
feature/CCM-24467_Implement_Mise_and_Prek
Open

jamesthompson26-nhs wants to merge 6 commits into
mainfrom
feature/CCM-24467_Implement_Mise_and_Prek

Conversation

@jamesthompson26-nhs

@jamesthompson26-nhs jamesthompson26-nhs commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • Updated the lint-terraform action to support both consumer setups:
    • Uses mise and mise.lock when the checkout has mise.toml.
    • Falls back to asdf and .tool-versions for legacy repositories.
    • Uses Terraform already on PATH if neither manager is available, and fails clearly if Terraform cannot be found.
  • Updated the Docker helpers to prefer .docker-versions and fall back to .tool-versions, including explicit project-specific version-file overrides. New-format pins take precedence when both files exist.
  • Added Docker helper regression coverage for legacy fallback, migrated-format pins, and precedence when both files are present.
  • Updated the lint-terraform action documentation to describe the setup required for both migrated and legacy consumers.
  • Validation: the daemon-free fallback and precedence test passes; ShellCheck, Bash syntax checks, whitespace checks, and the shared-modules pre-commit hooks pass except for the Terraform-docs hook, which is skipped because its module glob matches no files. The full Docker suite has not been run because Docker is unavailable.

Context

This is the compatibility phase of the asdf-to-mise rollout. It allows migrated and non-migrated consumer repositories to use the shared Terraform action and Docker helpers while shared-modules itself remains on its current asdf and pre-commit setup.

The existing .tool-versions, CI workflows and hooks remain in place. Shared-modules’ own migration to mise and prek will follow separately, after consumers have had time to migrate.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@jamesthompson26-nhs
jamesthompson26-nhs requested a review from a team as a code owner October 23, 2026 14:24
@jamesthompson26-nhs jamesthompson26-nhs changed the title Feature/ccm 24467 implement mise and prek CCM-24467: Implement Mise and Prek Oct 23, 2026
@jamesthompson26-nhs jamesthompson26-nhs changed the title CCM-24467: Implement Mise and Prek CCM-24467 Implement Mise and Prek Oct 23, 2026
@jamesthompson26-nhs jamesthompson26-nhs changed the title CCM-24467 Implement Mise and Prek CCM-24467: Implement Mise and Prek Oct 23, 2026
@jamesthompson26-nhs jamesthompson26-nhs added the skip-dependencies-check skip-dependencies-check label Oct 23, 2026
@jamesthompson26-nhs jamesthompson26-nhs changed the title CCM-24467: Implement Mise and Prek CCM-24467: Mise Compatibility Oct 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-dependencies-check skip-dependencies-check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant