CCM-18685: Deployed proxies should be deleted on PR close#639
Merged
Conversation
francisco-videira-nhs
added
the
deploy-proxy
francisco-videira-nhs
force-pushed
the
feature/CCM-18685
branch
from
July 13, 2026 14:34
842a88f to
0acf742
Compare
francisco-videira-nhs
force-pushed
the
feature/CCM-18685
branch
from
July 13, 2026 15:04
0acf742 to
8c4aaec
Compare
…ng crashes on arm64 The NHS Notify Shared Modules hook hardcodes --platform linux/amd64 in Docker invocation. With moby: false (full Docker daemon - now required due to Docker 4.82 Ubuntu resolute incompatibility), this forces amd64 emulation under QEMU, causing Go runtime crashes (SIGSEGV, GC corruption). With moby: true (Moby engine), the check was permissive and silently used arm64 native image despite the explicit amd64 flag. However, moby: true is no longer available on Ubuntu resolute, so it must stay false. Until the upstream hook is fixed to remove the --platform constraint, this hook is disabled for arm64 machines.
francisco-videira-nhs
force-pushed
the
feature/CCM-18685
branch
from
July 14, 2026 12:46
7300440 to
2027a6a
Compare
francisco-videira-nhs
force-pushed
the
feature/CCM-18685
branch
from
July 14, 2026 14:47
2027a6a to
a16bd28
Compare
This reverts commit 9057177.
…on causing crashes on arm64" This reverts commit a926fe6.
|
aidenvaines-cgi
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added step to destroy PR proxy on close.
Also refactored a couple confusing names and environments.
Context
Type of changes
Checklist
DT3-Specific Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.