Skip to content

feat(eventbridge): enhance bus name handling for disabled modules and update documentation - #136

Merged
nhs-oliverslater merged 2 commits into
mainfrom
build/BCSS-24413-flavour-level-SSM-parameter-inheritance-v2
Oct 27, 2026
Merged

nhs-oliverslater merged 2 commits into
mainfrom
build/BCSS-24413-flavour-level-SSM-parameter-inheritance-v2

Conversation

@nhs-oliverslater

@nhs-oliverslater nhs-oliverslater commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

Improve handling of EventBridge bus names when modules are disabled. Update documentation to clarify bus name behavior and provide examples.

Context

This change ensures that even when a module is disabled, it can still reference an existing EventBridge bus. It addresses potential confusion regarding bus name defaults and enhances usability.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT include PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that does contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhs-oliverslater
nhs-oliverslater requested review from a team as code owners October 27, 2026 09:35
Comment thread infrastructure/modules/eventbridge/tests/eventbridge.tftest.hcl Outdated
@nhs-oliverslater
nhs-oliverslater enabled auto-merge (squash) October 27, 2026 11:17
@nhs-oliverslater
nhs-oliverslater merged commit a2dfe3c into main Oct 27, 2026
17 checks passed
@nhs-oliverslater
nhs-oliverslater deleted the build/BCSS-24413-flavour-level-SSM-parameter-inheritance-v2 branch October 27, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants