Skip to content

NPA-6981: POC - change healthcheck URL #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davesmallnhs wants to merge 11 commits into
base: master
Choose a base branch
from
Open

NPA-6981: POC - change healthcheck URL #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3ea94c6
Change URL from Apigee mock to another public URL
davesmallnhs Jun 18, 2026
8a466b9
reqbin was protected by Cloudflare: use another public URL
davesmallnhs Jun 18, 2026
d2d71e6
Try to link up with a real healthcheck
davesmallnhs Jun 18, 2026
c53ea99
Remove apikey requirements from GET /_status
davesmallnhs Jun 19, 2026
8cad9b5
Experiment with SERVICE_BASE_PATH
davesmallnhs Jun 19, 2026
b9e00f4
Added verb
davesmallnhs Jun 19, 2026
18750a5
Putting Verb into the right place
davesmallnhs Jun 19, 2026
48ecd9e
Now it's working, try removing Verb to get the minimal changeset
davesmallnhs Jun 19, 2026
cc4911c
Added apikey requirement back in, to check that this reinstates a 401
davesmallnhs Jun 19, 2026
816d302
Re-removed the apikey check, so that _status is publicly accessible
davesmallnhs Jun 19, 2026
d2b3e2b
Merge branch 'master' into task/NPA-6981/poc-change-healthcheck-url
ellie-bound1-NHSD Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions proxies/live/apiproxy/policies/ServiceCallout.CallHealthcheckEndpoint.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,14 @@
<IgnoreUnresolvedVariables>false</IgnoreUnresolvedVariables>
</Request>
<Response>healthcheckResponse</Response>
<!-- <HTTPTargetConnection>-->
<!-- <SSLInfo>-->
<!-- <Enabled>true</Enabled>-->
<!-- </SSLInfo>-->
<!-- <LoadBalancer>-->
<!-- <Server name="validated-relationships-service-api" />-->
<!-- </LoadBalancer>-->
<!-- <Path>/_ping</Path>-->
<!-- </HTTPTargetConnection>-->
<HTTPTargetConnection>
<URL>http://mocktarget.apigee.net</URL>
<Properties>
<Property name="supports.http10">true</Property>
<Property name="request.retain.headers">User-Agent,Referer,Accept-Language</Property>
<Property name="retain.queryparams">apikey</Property>
</Properties>
<SSLInfo>
<Enabled>true</Enabled>
</SSLInfo>
<LoadBalancer>
<Server name="validated-relationships-service-api" />
</LoadBalancer>
<Path>/_status</Path>
</HTTPTargetConnection>
<Timeout>20000</Timeout>
</ServiceCallout>
4 changes: 0 additions & 4 deletions proxies/live/apiproxy/proxies/default.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@
</Flow>
<Flow name="StatusEndpoint">
<Request>
<Step>
<Condition>request.header.apikey = null or private.common.status-endpoint-api-key != request.header.apikey</Condition>
<Name>RaiseFault.401Unauthorized</Name>
</Step>
<Step>
<Name>ServiceCallout.CallHealthcheckEndpoint</Name>
</Step>
Expand Down