fix(python): avoid a runtime typing_extensions dependency - #705
Conversation
Signed-off-by: nachiketb <nachiketb@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe change removes the runtime ChangesServer import validation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The supported Server entry point avoids the runtime typing dependency and is covered by matching slim-install and wheel smoke checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit checks the server door Comment |
What
typing_extensions.Selfonly while type checking.Serverentry point.Why
A clean default install has no
typing_extensionsruntime dependency, butswitchyard_rust.serverimported it unconditionally. This made the supported server entry point fail before the native module could load.Validation
Serverimport on Python 3.10 withtyping_extensionsabsent.Serverimport on Python 3.14 withtyping_extensionsabsent.uv run ruff check switchyard_rust/server.pyuv run mypy switchyard_rust/server.pyFixes SWITCH-1425.
Summary by CodeRabbit