fix(packaging): include prefill-router in the Python sdist - #706
Conversation
Signed-off-by: nachiketb <nachiketb@nvidia.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. WalkthroughThe source distribution now includes required Rust build inputs. The publish workflow smoke-installs the distribution in isolated Python 3.10 and imports the Rust extension before upload. ChangesSource Distribution Validation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The source distribution includes the required build inputs and is smoke-installed and imported in isolation before upload. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit packs the Rust files tight Comment |
What
prefill-routercrate and the pinned Rust toolchain in Python source distributions.Why
The generated archive contained
switchyard-runner, but omitted its localprefill-routerdependency. Cargo therefore failed during package metadata generation. The archive also omitted the repository's pinned toolchain, which could leave clean builds below the declared Rust version.How
Maturin now includes only the prefill crate files needed to resolve and build the workspace dependency. The existing source-distribution job installs its generated archive in an isolated Python 3.10 environment and imports the native extension.
Validation
nemo_switchyard-0.2.0.tar.gzwith Maturin.rust-toolchain.toml.switchyard_rust._switchyard_rustfrom the installed archive.actionlintpassed for the release workflow.Fixes SWITCH-1427.
Summary by CodeRabbit
Chores
Tests