build: inherit prefill-router from the workspace - #710
Conversation
Signed-off-by: nachiketb <nachiketb@nvidia.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe workspace now defines ChangesWorkspace Dependency Configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The dependency centralization preserves the existing feature-enabled and feature-disabled build paths, with no merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit hops through Cargo’s gate Comment |
What
prefill-routerin the workspace dependency table.prefill-routerfeature.Why
prefill-routeris already a workspace member. Its path and version should have one source of truth, like the other shared crates. This keeps Git-based Cargo installs and workspace builds on the same dependency declaration.The crates.io publication order remains handled by #707 because optional registry dependencies must still be published.
Related to SWITCH-1444.
How
The root manifest owns the versioned path dependency.
switchyard-runnerinherits it withworkspace = trueand keepsoptional = true.Validation
cargo metadata --locked --no-deps --format-version 1cargo check --locked -p switchyard-runner --features prefill-routercargo +1.96.1 install --git https://github.com/NVIDIA-NeMo/Switchyard.git --branch nachiketb/build-workspace-prefill-dependency --locked --root /tmp/switchyard-git-install-default switchyard-server/tmp/switchyard-git-install-default/bin/switchyard-server --helpThe GitHub install completed and the installed executable ran successfully.
Summary by CodeRabbit