Skip to content

build: inherit prefill-router from the workspace - #710

Merged
ayushag-nv merged 1 commit into
mainfrom
nachiketb/build-workspace-prefill-dependency
Sep 15, 2026
Merged

ayushag-nv merged 1 commit into
mainfrom
nachiketb/build-workspace-prefill-dependency

Conversation

@nachiketb-nvidia

@nachiketb-nvidia nachiketb-nvidia commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

What

  • Declare prefill-router in the workspace dependency table.
  • Keep the runner dependency optional and inherit its path and version from the workspace.
  • Preserve the existing prefill-router feature.

Why

prefill-router is already a workspace member. Its path and version should have one source of truth, like the other shared crates. This keeps Git-based Cargo installs and workspace builds on the same dependency declaration.

The crates.io publication order remains handled by #707 because optional registry dependencies must still be published.

Related to SWITCH-1444.

How

The root manifest owns the versioned path dependency. switchyard-runner inherits it with workspace = true and keeps optional = true.

Validation

  • cargo metadata --locked --no-deps --format-version 1
  • cargo check --locked -p switchyard-runner --features prefill-router
  • cargo +1.96.1 install --git https://github.com/NVIDIA-NeMo/Switchyard.git --branch nachiketb/build-workspace-prefill-dependency --locked --root /tmp/switchyard-git-install-default switchyard-server
  • /tmp/switchyard-git-install-default/bin/switchyard-server --help

The GitHub install completed and the installed executable ran successfully.

Summary by CodeRabbit

  • Chores
    • Updated internal dependency management for the prefill routing component.
    • No user-facing features or behavior changes are included in this update.

Signed-off-by: nachiketb <nachiketb@nvidia.com>
@nachiketb-nvidia
nachiketb-nvidia requested a review from a team as a code owner September 15, 2026 20:05
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1

🚀 View preview at
https://NVIDIA-NeMo.github.io/Switchyard/pr-preview/pr-710/

Built to branch gh-pages at 2026-09-15 20:06 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d8c07608-2274-41d2-b947-db7df591f249

📥 Commits

Reviewing files that changed from the base of the PR and between f27abd6 and fc7c20f.

📒 Files selected for processing (2)
  • Cargo.toml
  • crates/switchyard-runner/Cargo.toml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The workspace now defines prefill-router version 0.2.0. switchyard-runner uses this workspace dependency while keeping it optional.

Changes

Workspace Dependency Configuration

Layer / File(s) Summary
Workspace dependency wiring
Cargo.toml, crates/switchyard-runner/Cargo.toml
The workspace adds the path dependency. switchyard-runner replaces its local dependency declaration with the workspace configuration.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to fc7c2

The dependency centralization preserves the existing feature-enabled and feature-disabled build paths, with no merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: moving the prefill-router dependency configuration to the workspace.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

A rabbit hops through Cargo’s gate
prefill-router now shares one state
The workspace holds version two
The runner keeps its option true
Clean paths guide the build along

Comment @coderabbitai help to get the list of available commands.

@ayushag-nv
ayushag-nv merged commit 5c34be4 into main Sep 15, 2026
22 checks passed
@ayushag-nv
ayushag-nv deleted the nachiketb/build-workspace-prefill-dependency branch September 15, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants