fix(translation): honor Chat streaming usage opt-in - #797
Closed
ajcasagrande wants to merge 2 commits into
Closed
ajcasagrande wants to merge 2 commits into
ajcasagrande wants to merge 2 commits into
Conversation
Signed-off-by: Anthony Casagrande <acasagrande@nvidia.com>
Signed-off-by: Anthony Casagrande <acasagrande@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA-NeMo/Switchyard/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. WalkthroughChangesOpenAI Chat streaming usage
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~30 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
A rabbit checks the streaming trail Comment |
Author
|
closing for now, while product alignment is conferred |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes generated OpenAI Chat streaming usage opt-in through
stream_options.include_usage. Requested usage now follows the finish chunk as onechoices: []frame at clean EOF. The relay test confirms hidden client output still emits answer-token telemetry.Why
OpenAI Chat callers that omit usage opt-in must not receive generated usage frames. This keeps provider raw replay unchanged while preserving clean-EOF ordering and telemetry behavior.
Notes for reviewers
Summary by CodeRabbit
New Features
Bug Fixes