Repository navigation
Conversation
Until a built-in's class registers, the asset lookup takes the assets/ folder of the built-in package under usersim/engine/probes/ that holds the probe's <label>/ folder: the package named after the probe, or else a package holding several probes. A test builds a package holding two probes and resolves each by its label. Signed-off-by: Yev Meyer <ymeyer@nvidia.com>
The four health probes keep their banks in probes/health_disclosure/assets/<label>/, the folder their base class names as its assets_root, beside the bank loader bank.py, realized_audit.py and the concealment scorer scorer.py. Their tests are in tests/probes/health_disclosure/. The labels, the scorer name, the banks, the stored columns and the caches are unchanged. DEFAULT_SCORER_MODULES and the docs name the new modules, the authoring guide and architecture/probes.md describe a folder several probes share, and the layout test accepts one. The shared-code label allowances do not list the bank loader, which sits under engine/probes/. A test reads a health probe's asset folder in a fresh process with no probe registered. Signed-off-by: Yev Meyer <ymeyer@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
The four health probes,
health_triage_disclosure,health_therapy_disclosure,health_decision_support_disclosureandhealth_general_disclosure, keep everything in the folder they share,probes/health_disclosure/: their bank loaderbank.py,realized_audit.py, the concealment scorerscorer.pyand their banks inassets/<label>/, the folder their base class names as itsassets_root. Their tests are intests/probes/health_disclosure/. The labels, the scorer name, the banks, the stored columns and the caches are unchanged.Builds on #125.
assets/folder of its package underusersim/engine/probes/. It takes the package named after the probe, or else the package whoseassets/holds the probe's folder, so a scorer, or a prompt read while a module loads, reaches the banks of a probe that shares its folder.core/clinical_profile_bank.pybecomesbank.py,core/realized_audit.pykeeps its name, and the scorer becomesscorer.py. The four banks move intoassets/, and the tests becometest_probe.py,test_scorer.py,test_bank.py,test_realized_audit.pyandtest_e2e.py.DEFAULT_SCORER_MODULESand the docs name the new modules, and the authoring guide andarchitecture/probes.mddescribe a folder several probes share.tool_calling.How it was verified
At each commit, on that commit's tree:
That is the first commit's tree; the second passes with 4657 tests as well.
At the head:
The first commit's test fails without its lookup change:
make health-checkran against a custom provider config forhealth_triage_disclosureinen_INandhealth_therapy_disclosureinfr_FR. Each ended with✓ simulate, eval and report all completed, and every model's requests showfailed=0.usersim simulate, eight turns ofhealth_triage_disclosureinen_USwithUSERSIM_DISCLOSURE_MOVES=1, thenusersim evalnaming the concealment scorer, ran against the same config:Results impact
Conversations, prompts and scores are unchanged. The setup fingerprint of a
simulate --inputsrun hashes the contents of every asset root, so it changes, as after any bank edit, and such a run gives its rows new trajectory ids rather than skipping rows it wrote before this change.