Skip to content

fix(cli): record the command in plain simulate's run manifest #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isarasua merged 3 commits into from
Oct 13, 2026
Merged

fix(cli): record the command in plain simulate's run manifest #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a645742
fix(cli): record the command in plain simulate's run manifest
isarasua Oct 11, 2026
9cedc93
Merge branch 'main' into isarasua/fix/simulate-manifest-invocation
isarasua Oct 12, 2026
d228e79
Merge branch 'main' into isarasua/fix/simulate-manifest-invocation
isarasua Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/usersim/cli/simulate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,6 @@ def _simulate_to_parquet(
assets_dir=Path(assets_dir).resolve(),
trajectories_requested=requested_per_locale,
persona_language_filters=applied_language_filters,
source_kind="cli",
)
print(f" manifest: {manifest_path_written}")
except Exception as e: # pragma: no cover — defensive: never fail a run on manifest issues
Expand Down
7 changes: 7 additions & 0 deletions tests/test_cli_simulate_run_partition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
from __future__ import annotations

import json
import sys
from pathlib import Path
from unittest.mock import patch

Expand Down Expand Up @@ -254,6 +255,10 @@ def _fake_builder(**kwargs):
return _FakeDD(), object()

models = load_models_config(default_models_path())
# The command line the manifest should record.
monkeypatch.setattr(sys, "argv", ["usersim", "simulate", "--locale", "en_US", "--num-rows", "1"])
monkeypatch.delenv("SLURM_JOB_ID", raising=False)
monkeypatch.setattr("usersim.engine.core.manifest._is_running_in_notebook", lambda: False)
with patch("usersim.cli._pipeline.build_simulator_config_builder", _fake_builder):
rc = _simulate_to_parquet(
models=models,
Expand Down Expand Up @@ -304,6 +309,8 @@ def _fake_builder(**kwargs):
assert fresh_manifest.scope.toolset_seed_path is None
assert fresh_manifest.scope.toolset_content_hash is None
assert fresh_manifest.simulation_config.store_reasoning is False
assert fresh_manifest.source.kind == "cli"
assert fresh_manifest.source.invocation == "usersim simulate --locale en_US --num-rows 1"
assert load_run_manifest("1700000000", out) is None

def test_simulate_helper_resumes_into_latest_when_skip_existing_true(
Expand Down
Loading